Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty fv3atm output bundle #1825

Merged
merged 17 commits into from
Jul 28, 2023

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Jul 6, 2023

Description

Fix model crash if one or the fv3atm output bundles does not have any field. See: NOAA-EMC/fv3atm#676

Input data additions/changes

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Library Updates/Changes

  • Not Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved in section below
  • Confirm reviews completed in ALL sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Depends on NOAA-EMC/fv3atm/issues/676

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

junwang-noaa
junwang-noaa previously approved these changes Jul 6, 2023
@jkbk2004
Copy link
Collaborator

@DusanJovic-NOAA We consider to combine this pr with #1811. can you sync up branch? so we can prepare.

@jkbk2004
Copy link
Collaborator

@DusanJovic-NOAA Once #1815 is ready, we will let #1815 go first though.

@DusanJovic-NOAA
Copy link
Collaborator Author

My branches are updated.

@jkbk2004
Copy link
Collaborator

@DusanJovic-NOAA Can you take a look at /scratch1/NCEPDEV/stmp2/Jong.Kim/FV3_RT/rt_98984/rrfs_smoke_conus13km_fast_phy32_qr_intel ? It crashes.

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA Can you take a look at /scratch1/NCEPDEV/stmp2/Jong.Kim/FV3_RT/rt_98984/rrfs_smoke_conus13km_fast_phy32_qr_intel ? It crashes.

I just updated FV3 submodule.

@DusanJovic-NOAA
Copy link
Collaborator Author

RegressionTests_hera.log

@DeniseWorthen DeniseWorthen added the No Baseline Change No Baseline Change label Jul 26, 2023
@zach1221
Copy link
Collaborator

Hello, @DusanJovic-NOAA . PR 1794 has been merged. Can you sync up your branch with develop and resolve conflicts here? That way we can begin testing through this PR next.

@BrianCurtis-NOAA
Copy link
Collaborator

@DusanJovic-NOAA @zach1221 could we add #1813 to this?

@zach1221
Copy link
Collaborator

@DusanJovic-NOAA @zach1221 could we add #1813 to this?

I'm ok with that, if Dusan is. I can just copy over the template and commit directly to this PR.

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA @zach1221 could we add #1813 to this?

I'm ok with that, if Dusan is. I can just copy over the template and commit directly to this PR.

I'm also ok with that.

@zach1221 zach1221 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Jul 27, 2023
@FernandoAndrade-NOAA FernandoAndrade-NOAA added the jenkins-ci Jenkins CI: ORT build/test on docker container label Jul 27, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator

Jenkins ci log is attached, ORTs passed.
ufs-weather-model » ort-docker-pipeline » PR-1825 #1 Console [Jenkins].txt

@FernandoAndrade-NOAA FernandoAndrade-NOAA added the hera-RT Run Hera regression testing label Jul 27, 2023
@FernandoAndrade-NOAA FernandoAndrade-NOAA added the jet-RT Run AutoRT Jet regression testing label Jul 27, 2023
@epic-cicd-jenkins epic-cicd-jenkins removed the jet-RT Run AutoRT Jet regression testing label Jul 27, 2023
@zach1221
Copy link
Collaborator

Testing is complete. I'll follow up on the fv3atm sub-pr to begin the merging process.

@BrianCurtis-NOAA
Copy link
Collaborator

New FV3 hash: NOAA-EMC/fv3atm@1158696

@zach1221
Copy link
Collaborator

@DusanJovic-NOAA fv3atm sub-pr #679 has been merged. Please update the submodule point revert the change in gitmodules.

@zach1221 zach1221 requested a review from jkbk2004 July 28, 2023 14:03
@zach1221 zach1221 merged commit e50a4c0 into ufs-community:develop Jul 28, 2023
@zach1221
Copy link
Collaborator

Closes #1813

@DusanJovic-NOAA DusanJovic-NOAA deleted the empty_output_bundle branch August 31, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-RT Run Hera regression testing jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

9 participants