Move Noah MP init to CCPP and add new variables for Noah MP #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e metadata in ccpp/data/GFS_typedefs.{F90,meta}
…hmp_init_in_ccpp
…a/GFS_typedefs.F90
climbfuji
requested review from
DusanJovic-NOAA,
barlage,
HelinWei-NOAA,
junwang-noaa and
SMoorthi-emc
DusanJovic-NOAA
approved these changes
Feb 23, 2021
barlage
approved these changes
Feb 23, 2021
|
In the compile log file, the ccpp_static_api.F90 with ccpp_physics_init and
ccpp_physics_run are build in FV3/ccpp/driver/libccppdriver.a, not in
FV3/ccpp/framework/src/libccpp.a. So it seems not from ccpp framework
…On Wed, Feb 24, 2021 at 9:20 AM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CMakeLists.txt
<#249 (comment)>:
> @@ -109,7 +108,9 @@ target_include_directories(fv3dycore INTERFACE $<BUILD_INTERFACE:${CMAKE_CURRENT
$<INSTALL_INTERFACE:mod>)
target_link_libraries(fv3dycore PUBLIC fms
- gfsphysics
The dycore does depend explicitly on ccpp=ccppframework, because it uses call
ccpp_physics_init etc.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#249 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TJYA4JPL3KPDXFBO7TTAUDK5ANCNFSM4X67L6LQ>
.
|
|
But they use the ccpp type ccpp_t, which is defined in FV3/ccpp/framework/src/ccpp_types.F90 !
… On Feb 24, 2021, at 7:34 AM, Jun Wang ***@***.***> wrote:
In the compile log file, the ccpp_static_api.F90 with ccpp_physics_init and
ccpp_physics_run are build in FV3/ccpp/driver/libccppdriver.a, not in
FV3/ccpp/framework/src/libccpp.a. So it seems not from ccpp framework
On Wed, Feb 24, 2021 at 9:20 AM Dom Heinzeller ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In CMakeLists.txt
> <#249 (comment)>:
>
> > @@ -109,7 +108,9 @@ target_include_directories(fv3dycore INTERFACE $<BUILD_INTERFACE:${CMAKE_CURRENT
> $<INSTALL_INTERFACE:mod>)
>
> target_link_libraries(fv3dycore PUBLIC fms
> - gfsphysics
>
> The dycore does depend explicitly on ccpp=ccppframework, because it uses call
> ccpp_physics_init etc.
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <#249 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AI7D6TJYA4JPL3KPDXFBO7TTAUDK5ANCNFSM4X67L6LQ>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#249 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RJGNGPE6CXGEY5NQQLTAUE7PANCNFSM4X67L6LQ>.
|
where cdata is from ccpp-framework (ccpp_t). Is this a direct or indirect dependency? Whatever, I'll remove the one line. |
|
I think that is implicit, fv3 dycore itself only needs ccpp_data and
ccpp_static_api
…On Wed, Feb 24, 2021 at 9:39 AM Dom Heinzeller ***@***.***> wrote:
use CCPP_data, only: ccpp_suite, &
cdata => cdata_tile, &
CCPP_interstitial
where cdata is from ccpp-framework (ccpp_t). Is this a direct or indirect
dependency? Whatever, I'll remove the one line.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#249 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TNO4KF3UT7IGNHISJDTAUFQ3ANCNFSM4X67L6LQ>
.
|
…hmp_init_in_ccpp
…WP updates, that permanently disabled the old GFS v12-v15 convective gravity wave drag scheme
…_reset call, remove RRTMGP variables from GFS_typedefs.meta that no longer exist, add missing active flags to RRTMGP variables in GFS_typedefs.meta
|
@dustinswales I added the rad_reset call for the gas concentrations that was missing in the last PR, and fixed a few RRTMGP issues in GFS_typedefs.meta. Please check commit 1d9c848. Thanks! |
climbfuji
force-pushed
the
noahmp_init_in_ccpp
branch
from
b06d1a1
to
67e831a
Compare
junwang-noaa
approved these changes
Mar 1, 2021
SMoorthi-emc
approved these changes
Mar 1, 2021
Yes, they are only used when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does several things:
io/FV3GFS_io.F90) to CCPP from @climbfuji.GFS_typedefs.F90.ccpp/data/GFS_typedefs.F90, made as part of the UGWP update PR (UGWP v0 v1 combined #241), that permanently disabled the old GFS v12-v15 convective gravity wave drag scheme. @SMoorthi-emc @ValeryYudin-NOAA please check, around line 4030 in the updatedGFS_typedefs.F90.GFS_typdefs.F90for the recently merged RRTMGP updates: AddInterstitial%gas_concentrations%concs(:)%concto theInterstitial%rad_resetcall, remove RRTMGP variables that no longer exist fromGFS_typedefs.meta, add missing active flags to RRTMGP variables inGFS_typedefs.metaIssue(s) addressed
This finally completes step 2 of #214.
Fixes #206.
Testing
For regression testing, see ufs-community/ufs-weather-model#425.
Dependencies
NCAR/ccpp-physics#575
#249
ufs-community/ufs-weather-model#425