Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Land surface upgrades for HR2 #663

Merged
merged 35 commits into from
Jul 19, 2023
Merged

Conversation

HelinWei-NOAA
Copy link
Contributor

@HelinWei-NOAA HelinWei-NOAA commented Jun 2, 2023

Description

Land surface upgrades for HR2. The detail can be found from ccpp-physics PR #78

Is a change of answers expected from this PR? Yes

Issue(s) addressed

global workflow issue 1614
global workflow issue 1617

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@BrianCurtis-NOAA
Copy link
Collaborator

This needs reviews before the UFSWM PR can get into the commit queue.

@DusanJovic-NOAA
Copy link
Collaborator

This branch (HelinWei-NOAA:hr2_land1) is 5 commits behind develop

@HelinWei-NOAA
Copy link
Contributor Author

I will update to the current after I finish updating FV3 (Sam refactored FV3GFS_io.F90 last week).

@HelinWei-NOAA
Copy link
Contributor Author

@DusanJovic-NOAA The code is now up-to-date with the develop.

@jkbk2004 jkbk2004 requested review from DusanJovic-NOAA and barlage and removed request for DusanJovic-NOAA and barlage June 30, 2023 14:36
Copy link

@barlage barlage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't see any issues.

@FernandoAndrade-NOAA
Copy link

Requesting @BrianCurtis-NOAA @jkbk2004 @Qingfu-Liu @zach1221 for review and approvals. Apologies, I don't have permissions to add reviewers to this PR.

@Qingfu-Liu Qingfu-Liu assigned Qingfu-Liu and unassigned Qingfu-Liu Jul 13, 2023
@Qingfu-Liu Qingfu-Liu self-requested a review July 13, 2023 19:26
@grantfirl
Copy link
Collaborator

@HelinWei-NOAA ufs-community/ccpp-physics#78 was merged. Please update the ccpp/physics submodule pointer and revert .gitmodules.

@HelinWei-NOAA
Copy link
Contributor Author

@grantfirl Done.

@HelinWei-NOAA ufs-community/ccpp-physics#78 was merged. Please update the ccpp/physics submodule pointer and revert .gitmodules.

@FernandoAndrade-NOAA
Copy link

Ok, this PR is ready to continue with merge process @jkbk2004

@FernandoAndrade-NOAA
Copy link

@jkbk2004 The noahmp #7 PR was merged in. I believe this is ready as well

@jkbk2004 jkbk2004 merged commit e7dc085 into NOAA-EMC:develop Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants