Changes to Logging and Initialization of the CLM Lake Model

[SamuelTrahanNOAA]

Description

This is the work of @tanyasmirnova to fix some initialization issues in the CLM Lake Model. Initialization appears to work correctly without fractional ice. There are some lingering issues with fractional ice initialization that we're working on.

Changes:

1. Use ice thickness hice(i) to find the level in the lake where ice is zero.
2. Do not allow lake temperature to be below freezing point if there is no ice.
3. If there is no snow or ice, do not allow surface lake temperature to be below freezing point. These changes fixed the problem with large errors in the energy budget at the beginning of the cold-start run with lakes.
4. Added flag to turn on debug print statements in the CLM lake model.
5. Turned on fractional ice by default. Users running flake must turn it off explicitly, using frac_ice=.false. in the gfs_physics namelist.
6. Corrections to metadata of lake_q2m in GFS_diagnostics.F90

Issue(s) addressed

• CLM Lake initialization issues cause an energy budget problem ufs-community/ccpp-physics#93

Testing

How were these changes tested?

Staged test case on Hera.

What compilers / HPCs was it tested with?

Hera intel & gnu

Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)

Yes, the tests already exist.

Have the ufs-weather-model regression test been run? On what platform?

Yes, but this is not the final version of the code. I'll rerun them again when we're finished.

Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.

Any tests that use clm lake with lake data will change results due to the changes to clm lake initialization.

Please commit the regression test log files in your ufs-weather-model branch

Will do.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

• waiting on Changes to Logging and Initialization of the CLM Lake Model ufs-community/ccpp-physics#92

[zach1221]

@SamuelTrahanNOAA ccpp physics PR#92 has been merged. Please update the submodule pointer and gitmodule url for this fv3atm PR.
ccpp-physics hash: 5b946850af58e1cea8c37661158b661df21e9390

[SamuelTrahanNOAA]

Please update the submodule pointer and gitmodule url for this fv3atm PR.

Done.