Fix the broken error detection in GFS_phys_time_vary.fv3.F90 and pointer issues in c3 scheme #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. detect empty errmsg from subroutines 2. Initialize err variables in set_soilveg.f, which is called from GFS_phys_time_vary.fv3.F90
35 tasks
SamuelTrahanNOAA
changed the title
|
Merged via #695 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were several bugs in the error detection in GFS_phys_time_vary.fv3.F90. Errors might go undetected, or may be reported incorrectly.
Issue(s) addressed
noahmptable.tblfile is mandatory, even for configurations that don't need it. ufs-community/ccpp-physics#107Testing
How were these changes tested?
Hera regression tests.
What compilers / HPCs was it tested with?
Intel and gnu on Hera.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Failures are sporadic. However, there are enough regression tests that the failures will be detected, as long as jobs are not automatically resubmitted.
Have the ufs-weather-model regression test been run? On what platform?
Yes. Hera.
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
No.
Please commit the regression test log files in your ufs-weather-model branch
Done.
Dependencies