Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for ccpp-physics routine sfcsub.F #827

Closed

Conversation

GeorgeGayno-NOAA
Copy link
Contributor

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Apr 26, 2024

Description

No changes to fv3atm other than pointing to a new version of the ccpp physics to
address a bug in sfcsub.F routine.

Issue(s) addressed

Fixes ufs-community/ccpp-physics#199

Testing

Full set of ufs-weather-model regression tests were run on Hera and passed.

Dependencies

@DusanJovic-NOAA
Copy link
Collaborator

The title of this PR is "Test fix to ...". Is this just for testing the fix, or is this intended to be actually merged into develop branch? @GeorgeGayno-NOAA

@GeorgeGayno-NOAA
Copy link
Contributor Author

The title of this PR is "Test fix to ...". Is this just for testing the fix, or is this intended to be actually merged into develop branch? @GeorgeGayno-NOAA

According to the CCPP repository wiki page (see step 4), any changes to CCPP must also include PRs for FV3ATM and UFS weather model:

https://github.com/ufs-community/ccpp-physics/wiki#instructions-for-ccpp-physics-code-developers

I did not make any changes to FV3ATM itself.

@DusanJovic-NOAA
Copy link
Collaborator

The title of this PR is "Test fix to ...". Is this just for testing the fix, or is this intended to be actually merged into develop branch? @GeorgeGayno-NOAA

According to the CCPP repository wiki page (see step 4), any changes to CCPP must also include PRs for FV3ATM and UFS weather model:

https://github.com/ufs-community/ccpp-physics/wiki#instructions-for-ccpp-physics-code-developers

I did not make any changes to FV3ATM itself.

I was actually asking about the title itself. The "Test fix to ..." implies that this is just for testing. But since this needs to be merged into fv3atm the title should be "Bug fix for ccpp-physics routine sfcsub.F" like the corresponding ufs PR.

@GeorgeGayno-NOAA GeorgeGayno-NOAA changed the title Test fix to ccpp physics routine sfcsub.F Bug fix for ccpp-physics routine sfcsub.F May 3, 2024
@grantfirl
Copy link
Collaborator

grantfirl commented May 7, 2024

@jkbk2004 @DusanJovic-NOAA This is combined into #831 and therefore it can be closed.

@jkbk2004 jkbk2004 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sfcsub.F - bug in interpolation of GLDAS data
4 participants