Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FV3 Changes for using canopy resistance (rca) in Noah-MP for the AQM. #830

Closed
wants to merge 17 commits into from

Conversation

drnimbusrain
Copy link

Description

This PR is associated with changes to ccpp-physics at: ufs-community/ccpp-physics#204, which are proposed to add initial total canopy resistance (rca) calculation in Noah-MP, which is needed for coupling to the Air Quality Model (AQM) component. The rca calculation is based on Bonan et al. (2011) from the CLM4, and is used in the WRF version of the Noah-MP model.

Issue(s) addressed

#829

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Compiled with UFS-SRW-App on RDHPCs, Hera.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
No.
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
    No.
  • Please commit the regression test log files in your ufs-weather-model branch

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@grantfirl
Copy link
Collaborator

grantfirl commented May 7, 2024

@jkbk2004 @DusanJovic-NOAA This is combined into #831 and therefore it can be closed.

@jkbk2004 jkbk2004 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants