Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'DEBUG' option in build_ufs.sh #1187

Closed
mdtoyNOAA opened this issue Dec 16, 2022 · 0 comments
Closed

Fix 'DEBUG' option in build_ufs.sh #1187

mdtoyNOAA opened this issue Dec 16, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@mdtoyNOAA
Copy link
Contributor

Expected behavior

When compiling the ufs_model with sorc/build_ufs.sh and the "-d" option, the model should be compiled with "--DEBUG=ON".

Current behavior

Line 16 of the code assigns "BUILD_TYPE" to "Debug" (mixed case) when option "-d" passed in, however, the logic test on line 31 tests for BUILD_TYPE = "DEBUG" (all caps), so the debug mode can never be invoked.

Machines affected

All machines.

To Reproduce

This is a trivial problem. Easy to reproduce.

Detailed Description

The fix is trivial and it is to change "Debug" to "DEBUG" in line 16 of sorc/build_ufs.sh.

Note
I will submit a PR regarding this fix.

@mdtoyNOAA mdtoyNOAA added the bug Something isn't working label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants