Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HPSS_PROJECT configurable like ACCOUNT is #1585

Closed
CoryMartin-NOAA opened this issue May 8, 2023 · 3 comments · Fixed by #1603
Closed

Make HPSS_PROJECT configurable like ACCOUNT is #1585

CoryMartin-NOAA opened this issue May 8, 2023 · 3 comments · Fixed by #1603
Labels
feature New feature or request

Comments

@CoryMartin-NOAA
Copy link
Contributor

Description
Many things are templated in parm/config/config.base.emc.dyn but HPSS_PROJECT is not. Not all users are able to write to emc-global, this should be configurable like how ACCOUNT is.

Requirements
Have HPSS_PROJECT filled in by setup_expt.py

Acceptance Criteria (Definition of Done)
When the requirement is met

(Optional): Suggest A Solution

  • change to a template in parm/config/config.base.emc.dyn
  • modify workflow/setup_expt.py as appropriate to make the default emc-global but accept optional values if specified.
@CoryMartin-NOAA CoryMartin-NOAA added the feature New feature or request label May 8, 2023
@CoryMartin-NOAA
Copy link
Contributor Author

@aerorahul @WalterKolczynski-NOAA I didn't test this yet, perhaps this issue is moot and can be already done with the existing infrastructure put in place recently to overwrite defaults. Just wanted to capture it in an issue just in case work was needed to make this work.

@CoryMartin-NOAA
Copy link
Contributor Author

Update: looks like ACCOUNT doesn't even work by modifying config.base through a YAML file... I think it is because @ACCOUNT@ is already replaced by fv3-cpu before the script even reads the YAMLs.

@CoryMartin-NOAA
Copy link
Contributor Author

Work is ongoing and a PR to be issued "soon"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
1 participant