Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqlite3 interface #17

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Add sqlite3 interface #17

merged 4 commits into from
Mar 7, 2024

Conversation

aerorahul
Copy link
Contributor

Description
This PR:

  • adds a simple interface to interact with a sqlite3 database

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • pynorms
  • pytests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 50.57%. Comparing base (dd9ca24) to head (3c60321).

Files Patch % Lines
src/wxflow/sqlitedb.py 92.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #17      +/-   ##
===========================================
+ Coverage    48.87%   50.57%   +1.70%     
===========================================
  Files           15       16       +1     
  Lines         1416     1473      +57     
  Branches       308      313       +5     
===========================================
+ Hits           692      745      +53     
- Misses         670      672       +2     
- Partials        54       56       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I liked cleaning up my code with this. I did notice there was no tests for writing out a file.

@aerorahul aerorahul merged commit 97159f7 into develop Mar 7, 2024
15 checks passed
@aerorahul aerorahul deleted the feature/sqlite3 branch March 7, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants