-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create task_config member variable upon initialization #30
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #30 +/- ##
===========================================
+ Coverage 47.93% 48.17% +0.23%
===========================================
Files 18 18
Lines 1650 1642 -8
Branches 335 334 -1
===========================================
Hits 791 791
+ Misses 799 791 -8
Partials 60 60 ☔ View full report in Codecov by Sentry. |
…2700) This PR updates the `gdas.cd` hash to bring in new JCB conventions. Resolves #2699 From #2654 This PR will move much of the staging code that take place in the python initialization subroutines of the variational and ensemble DA jobs into Jinja2-templated YAML files to be passed into the wxflow file handler. Much of the staging has already been done this way, but this PR simply expands that strategy. The old Python routines that were doing this staging are now removed. This is part of a broader refactoring of the pygfs tasking. wxflow PR [#30](NOAA-EMC/wxflow#30) is a companion to this PR. Co-authored-by: danholdaway <danholdaway@users.noreply.github.com> Co-authored-by: DavidNew-NOAA <david.new@noaa.gov> Co-authored-by: DavidNew-NOAA <134300700+DavidNew-NOAA@users.noreply.github.com> Co-authored-by: Dan Holdaway <27729500+danholdaway@users.noreply.github.com>
Description
This PR creates the
task_config
member variable in theTask
__init__
function. Normally it is created upon initialization of a child subclasses ofTask
, but since it is expected to exist for every application of theTask
class I've seen so far, it's better to create it at initialization.This PR also eliminates
runtime_config
, since it's mostly redundant and renames theconfig
member variable with a leading underscores to emphasize that they should be treated as private.This PR is a companion to Global Workflow PR #2654 which replaces any reference to
config
orruntime_config
member variables withtask_config
.Type of change
How Has This Been Tested?
Checklist