-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create replace_tmpl filter for Jinja2 #33
Merged
aerorahul
merged 8 commits into
NOAA-EMC:develop
from
DavidNew-NOAA:feature/replace_tmpl
Jun 14, 2024
Merged
Create replace_tmpl filter for Jinja2 #33
aerorahul
merged 8 commits into
NOAA-EMC:develop
from
DavidNew-NOAA:feature/replace_tmpl
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33 +/- ##
===========================================
+ Coverage 48.17% 48.23% +0.06%
===========================================
Files 18 18
Lines 1642 1644 +2
Branches 334 335 +1
===========================================
+ Hits 791 793 +2
Misses 791 791
Partials 60 60 ☔ View full report in Codecov by Sentry. |
aerorahul
reviewed
Jun 13, 2024
aerorahul
reviewed
Jun 13, 2024
aerorahul
reviewed
Jun 14, 2024
aerorahul
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a filter for Jinja2 rendering called replace_tmpl that takes a string and replaces substrings defined in an input dictionary. The motivation is for when we want to replace multiple substrings in a template in the Global Workflow.
This PR also changes the copy() method that creates task_config in the Task class to deepcopy(), since in at least one case in the Global Workflow, a task_config key points to another dictionary.
Type of change
How Has This Been Tested?
ATM JJOB tests in GDASApp on Orion
Checklist