-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tranlon
in axis_utils2
returns erroneous istrt
value when no elements are moved
#1156
Comments
fixed with #1172 |
PR #1172 didn't really fix this, except superficially by commenting out the relevant test case. The question that I don't know the answer to is: do we fix the bug (which could potentially break users' code, since |
@J-Lentz I think you should update the documentation for this corner case. |
Describe the bug
tranlon
's Doxygen comment states:The first istrt-1 entries are moved to the end of the array
But in the case where no elements are moved,
tranlon
setsistrt
to 0, rather than the expected value of 1.To Reproduce
Expected behavior
istrt=1
Additional context
If changing the behavior would break users' code, then it could be argued that the inconsistent
istrt=0
return value is acceptable and that the error lies in the Doxygen comment.The text was updated successfully, but these errors were encountered: