Mixed precision axis_utils unit tests - Let's try again

[J-Lentz]

Description
Unit tests have been implemented for all procedures in axis_utils2 which deal with real numbers (as well as get_axis_cart, which does not).

Fully implemented tests

• axis_edges (already existed)
• get_axis_cart
• lon_in_range
• frac_index
• nearest_index
• tranlon

Skeletal tests (to be fully implemented at a later time)

• interp_1d_1d
• interp_1d_2d
• interp_1d_3d

Not yet implemented

• get_axis_modulo
• get_axis_modulo_times

Tests which fail

• tranlon: Fails due to unexpected behavior when no elements are translated: istrt is set to 0, when the expected value is 1. Should tranlon be changed, or should the test be changed? See: tranlon in axis_utils2 returns erroneous istrt value when no elements are moved #1156
• tranlon: In addition, the tranlon tests fail with gcc due to out-of-bound memory access: See: tranlon in axis_utils2 accesses and modifies out-of-bound memory #1137
• get_axis_cart fails due to a string copy error when an axis or cartesian_axis attribute is set to an unexpected value (lines 172-175 of test_axis_utils.F90). Should get_axis_cart be changed, or should this be considered a user error and removed from the test?

How has this been tested?
Tests compile and run on the AMD box with gcc and ifort.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• New check tests, if applicable, are included
• make distcheck passes

[thomas-robinson]

This needs more documentation.

[rem1776]

Something seems to be causing it to hang indefinitely while running the tests. Thought it might have been the outage, but github status shows everything as up now.

Looks like this test was the issue when I ran it in the CI image (gcc 9):

FAIL: test_axis_utils2.sh 16 - Testing axis utils: ./test_axis_utils_r8 --tranlon

Interestingly, the r4 version of the tranlon test is fine. Maybe this is related to the commented out lines in test?

[J-Lentz]

Something seems to be causing it to hang indefinitely while running the tests. Thought it might have been the outage, but github status shows everything as up now.

Looks like this test was the issue when I ran it in the CI image (gcc 9):

FAIL: test_axis_utils2.sh 16 - Testing axis utils: ./test_axis_utils_r8 --tranlon

Interestingly, the r4 version of the tranlon test is fine. Maybe this is related to the commented out lines in test?

This is almost certainly due to tranlon's out-of-bound memory bug (#1137). It corrupts 8 bytes of memory in the r8 version, which seems to have more catastrophic consequences than the r4 version which merely corrupts 4 bytes.

[rem1776]

@J-Lentz Nice, we can skip that test to get the CI passing for now since theres already a issue and PR for it. We'll just need to remember to re-enable it later on when the fix is in.

If you set this in the script it should show the test as skipped and pass:

SKIP_TESTS="test_axis_utils2.16"