Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two test updates that didn't make it in #104 #124

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

ceblanton
Copy link
Contributor

  • Skip the Test04 parallel tests only if requested (i.e. potentially run through CI)
  • Compare the serially and parallel fregrid output

@ceblanton ceblanton force-pushed the testing_input_more branch 2 times, most recently from 60f8107 to fb2e0a5 Compare October 14, 2021 19:26
@ceblanton
Copy link
Contributor Author

@ngs333, this adds a nccmp check for the parallel part of Test15 and uses different (improved?) logic for skipping the slow Test04 on the github runners (as it's way too slow). I wanted to allow the option of running the parallel part of Test04 through CI and skip it in the github runners. It works, but not sure it's a good approach. @rem1776 what do you think?

@rem1776
Copy link
Contributor

rem1776 commented Oct 14, 2021

@ceblanton Sorry I guess I missed that nccmp, but looks great, it's probably much better to skip it in the workflow file rather than check that variable in the script since it can run elsewhere. I guess it'll be skipping the whole test for mpi jobs not just the parallel section but that should be fine since the non-mpi jobs are running it anyway.

@ceblanton ceblanton merged commit 567493a into NOAA-GFDL:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants