Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GFDL compiler settings from Intel to GCC #153

Merged
merged 8 commits into from
May 5, 2022
Merged

Update GFDL compiler settings from Intel to GCC #153

merged 8 commits into from
May 5, 2022

Conversation

ceblanton
Copy link
Contributor

#99

@ceblanton
Copy link
Contributor Author

@ngs333 I tested the 3 configs and they all compiled and passed tests (except for the omgg). However, I have zero build options which is probably not right, and I don't know what we want.

ngs333
ngs333 reviewed Apr 22, 2022
View reviewed changes
site-configs/ncrc/config.site
@@ -29,10 +29,10 @@ test -z "$CC" && CC=cc
test -z "$FC" && FC=ftn

# Compile/Link flags
test -z "$CFLAGS" && CFLAGS="-xSSE2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chris, The Intel default optimization flag is -O2. The GNU default optimization flag is -O0.
So we need to add the -O2 flag whenever we use gcc. Thats for both CFLAGS and FCFLAGS.

ngs333
ngs333 suggested changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@ngs333 ngs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Intel default optimization flag is -O2. The GNU default optimization flag is -O0.
So we need to add the -O2 flag whenever we use gcc. Thats for both CFLAGS and FCFLAGS.

@ceblanton ceblanton requested a review from ngs333 April 22, 2022 17:49
@ngs333 ngs333 linked an issue Apr 22, 2022 that may be closed by this pull request
Switch GFDL site configurations to GCC #99
Closed
@ceblanton ceblanton marked this pull request as ready for review April 28, 2022 13:49
@ceblanton ceblanton requested a review from ngs333 April 28, 2022 13:50
@ngs333 ngs333 merged commit 7e6541b into NOAA-GFDL:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngs333 ngs333 ngs333 approved these changes

Assignees

@ceblanton ceblanton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch GFDL site configurations to GCC
2 participants
@ceblanton @ngs333