Fix to runoff_regrid.c #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files mpp.c and mpp_domain.c shared three variables. This sharing is removed. Both files now have `static` global variables. Cleaned up a few error messages in make_hgrid.c and remap_land.c Added .vscode mac configuration.
grabbing Seth's FRE-NCtools changes into my current fork
…LL,NULL) to set the right integer values for npes, pe, root_pe only small changes to test_utils.bash, remove unnecessary comment and add in comment text showing SKIP_TESTS example
ngs333
approved these changes
Nov 17, 2022
ceblanton
reviewed
Nov 21, 2022
| } | ||
| ], | ||
| "version": 4 | ||
| } |
There was a problem hiding this comment.
Was including this vscode config file intentional? It looks useful but might be specific to @ilaflott's setup.
There was a problem hiding this comment.
@ceblanton it was intentional. It is specific to a mac using homebrew. The configuration name should be more specific. However, don't worry about it ATT.
ceblanton
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test07-runoff_regrid.sh runs to completion on MacOS 12.5/Intel upon change to runoff_regrid.c.