-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved ax_lib_netcdf.m4 #23
Conversation
45b5375
to
89fb8c4
Compare
The check are failing due to |
A large refactor of the ax_lib_netcdf.m4 macros. This update better supports systems that don't have working n[cf]-config applications More work still needs to be done, as there are large sections that are essentially copy/replacre and can be better organized
89fb8c4
to
9ef09b1
Compare
FYI, I also checked that it builds on AMD + Ubuntu Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked over the code, and just to do a simple test, I installed this on Orion and it worked. As long as you know why the checks are failing and feel it is ready to merge, it looks good to me.
The tests are failing due to not having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only tested compilation on Gaea and Skylake where there were no difficulties setting the NetCDF configurations with nc-config, so it wasn't an extensive test. The comments in the .m4 file are very helpful :D
A large refactor of the ax_lib_netcdf.m4 macros. This update better supports systems that don't have working n[cf]-config applications
More work still needs to be done, as there are large sections that are essentially copy/replace and can be better organized.
Fixes #19