Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ax_lib_netcdf.m4 #23

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

underwoo
Copy link
Member

@underwoo underwoo commented Dec 1, 2020

A large refactor of the ax_lib_netcdf.m4 macros. This update better supports systems that don't have working n[cf]-config applications

More work still needs to be done, as there are large sections that are essentially copy/replace and can be better organized.

Fixes #19

@underwoo
Copy link
Member Author

underwoo commented Dec 1, 2020

The check are failing due to csh not being available in the Docker image. Although, if csh were available the checks would still fail as the scripts are written for use on the NOAA RDHPCS PPAN system. #22 should fix that problem.

A large refactor of the ax_lib_netcdf.m4 macros.  This update better supports systems that don't have working n[cf]-config applications

More work still needs to be done, as there are large sections that are essentially copy/replacre and can be better organized
@ngs333
Copy link
Contributor

ngs333 commented Dec 2, 2020

FYI, I also checked that it builds on AMD + Ubuntu Linux.

Copy link

@laurenchilutti laurenchilutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked over the code, and just to do a simple test, I installed this on Orion and it worked. As long as you know why the checks are failing and feel it is ready to merge, it looks good to me.

@underwoo
Copy link
Member Author

underwoo commented Dec 4, 2020

I've looked over the code, and just to do a simple test, I installed this on Orion and it worked. As long as you know why the checks are failing and feel it is ready to merge, it looks good to me.

The tests are failing due to not having csh or the sample data for one or more of the tests. There will be issues and PRs to resolve those later.

Copy link

@mlee03 mlee03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only tested compilation on Gaea and Skylake where there were no difficulties setting the NetCDF configurations with nc-config, so it wasn't an extensive test. The comments in the .m4 file are very helpful :D

@underwoo underwoo added this to the 2021.01 milestone Dec 9, 2020
@ngs333 ngs333 merged commit aacb2b4 into NOAA-GFDL:master Dec 11, 2020
@underwoo underwoo deleted the 19-improved.ax_lib_netcdf branch May 7, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with simple_hydrog and netCDF-Fortran
6 participants