Added fix for blocking factor of 0 in mppnccombine #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rem1776
requested changes
Feb 9, 2024
rem1776
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the working fix in mppnccombine.c. A bug occurred when the blocking factor (
bf) was set to 0 with the flag-k 0. In this case, if the number of records (nrecs) exceeded the maximum block size (MAX_BF) and the number of records was not an integer multiple ofMAX_BF, time slices would have been lost.The fix addresses this issue by ensuring that the correct number of blocks (
nblocks) is calculated even when (bf) is set to 0. A subtest has been created inTest02-mppnccombine.shthat tests for this edge case wherebfis set to 0.Fixes #272