CI container update and fix for log files #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngs333
reviewed
Dec 17, 2020
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| with_mpi: ['','--with-mpi'] | ||
| enable_quad_precision: ['', '--enable-quad-precision'] | ||
| env: | ||
| container: | ||
| image: ryanmulhall/fre-nctools-base |
There was a problem hiding this comment.
@rem1776 Ryan, Would you know if the directory of an individual is required to be used here?
There was a problem hiding this comment.
Currently we don't have a central public container registry or dockerhub account and to run the action this way requires a registry to pull the image from. I believe this should change soon though as the container project moves along and then i can migrate it to whichever to solution we go with.
ngs333
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the GitHub actions file to pull and run on a stored container image, and removes the docker recipe file and run script.
The Github Action's steps will run on the container directly as opposed to building an image and then running through docker commands and a run script, which fixes an issue with the testing logs getting saved and allows you to easily see if a build failed from configuring, building, or testing.
***side note: the last merge (with #27) seems to still fail with these updates when i tested the merge. From the log file, it looks like some sort of memory allocation error but I'm not sure why it would only be happening within the CI. You can download it here.