Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright #43

Merged
merged 6 commits into from
Feb 10, 2021
Merged

Copyright #43

merged 6 commits into from
Feb 10, 2021

Conversation

ngs333
Copy link
Contributor

@ngs333 ngs333 commented Jan 22, 2021

This PR adds uniform licencing headers to all code (Fortran, c, sh and csh shell scripts) Makefile.am and config.site files.
The header texts is the same, but there are three different comment symbols used (! and !# for Fortran, /* for C code, and # for scripts and text files).

Prior copyright and licencing statements were left in place, but the mention of the file "COPYING" was removed, and
the new licencing header was placed above the original statements. The File COPYING was also removed from all directories. We have only one LICENSE.md file in its place.

Update 2/5/2020:
The new licencing statement was not placed above original licencing statements that claimed the file is part of FMS.

@ngs333
Copy link
Contributor Author

ngs333 commented Jan 22, 2021

Testing was done on Gaea. As usual, only test 26 failed.

postprocessing/timavg/timavg.csh Show resolved Hide resolved
tools/simple_hydrog/libfmslite/horiz_interp.F90 Outdated Show resolved Hide resolved
tools/simple_hydrog/libfmslite/constants.F90 Outdated Show resolved Hide resolved
tools/simple_hydrog/libfmslite/horiz_interp_bilinear.F90 Outdated Show resolved Hide resolved
tools/simple_hydrog/libfmslite/horiz_interp_type.F90 Outdated Show resolved Hide resolved
tools/simple_hydrog/libfmslite/mpp.F90 Outdated Show resolved Hide resolved
Copy link
Member

@underwoo underwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made single comments on some changes, however they apply to multiple files.

postprocessing/land_utils/combine-ncc.F90 Outdated Show resolved Hide resolved
postprocessing/land_utils/combine-ncc.F90 Outdated Show resolved Hide resolved
postprocessing/list_ncvars/list_ncvars.csh Show resolved Hide resolved
Miguel Zuniga added 3 commits February 5, 2021 19:01
…ing header

mentioning NCTools when there was already one metioning FMS.
… terms of

the GNU General Public License" which appeared under some Copyright statements.
@ngs333 ngs333 mentioned this pull request Feb 10, 2021
@ngs333 ngs333 merged commit 7b36fbc into NOAA-GFDL:master Feb 10, 2021
@ngs333 ngs333 linked an issue Feb 10, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Licensing needs to be implemented throughout the project
4 participants