Test.updates #73
Merged
Test.updates #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added setup and teardown functions for the bats tests
rem1776
approved these changes
Mar 25, 2021
ceblanton
reviewed
Mar 26, 2021
ceblanton
approved these changes
Mar 26, 2021
ngs333
reviewed
Mar 26, 2021
| @@ -79,103 +68,4 @@ | |||
| --dst_cold_restart dst_cold_restart/land.res \ | |||
| --remap_file remap_file_C48_to_C192 --print_memory | |||
| [ "$status" -eq 0 ] | |||
|
|
|||
There was a problem hiding this comment.
@underwoo @ceblanton
Are we getting rid of these other remap_land tests?
Nevermind.
ngs333
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rem1776 I updated a few of the tests using additional
batsitems. This should do a better job at cleaning up after the tests (even failed tests). I needed to do this while tracking down a failing tests -- the old method did not clean up after a test failed, causing future tests to fail.I suggest updating the other tests with similar modifications.