202305 Release of SHiELD_physics #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the interface of the COSP and call COSP only at the diagnostic time step See merge request fv3team/fv3_gfsphysics!57
Shallow convection modification See merge request fv3team/fv3_gfsphysics!59
two bug fixes for modified shallow convection scheme (imfshalcnv=4) See merge request fv3team/fv3_gfsphysics!60
remove unused microphysics 3d diagnostics See merge request fv3team/fv3_gfsphysics!61
Update namelist reading code to avoid model crash because of the absence of naemlist. See merge request fv3team/fv3_gfsphysics!62
write out variables needed for COSP offline run See merge request fv3team/fv3_gfsphysics!63
Add the options to sub cycling condensation evaporation, control the time scale of evaporation, and delay condensation and evaporation. See merge request fv3team/fv3_gfsphysics!64
Cleanup and convenience features See merge request fv3team/fv3_gfsphysics!66
Remove grid size in energy and mass calculation. See merge request fv3team/fv3_gfsphysics!67
202303 Jan-Huey Chen See merge request fv3team/fv3_gfsphysics!68
Pass the namelist variables from the dycore to the physics during the initialization See merge request fv3team/fv3_gfsphysics!69
This was referenced Jun 1, 2023
lharris4
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Looks good to me, although @linjiongzhou would be a better reviewer of this code.
Thanks
Lucas
|
The microphysics part looks good to me. Thank you! @gaokun227 created the gsmphys/mfshalcnv_gfdl.f. He should take a look too. |
|
Looks good to me |
bensonr
approved these changes
Jun 2, 2023
Comment on lines
+2836
to
+2839
| if (Model%ntke < 1 .or. Model%ntke > Model%ntrac) then | ||
| write(*,*) ' FATAL GFS_typedefs: TKE PBL scheme enabled (satmedmf) but TKE tracer not found in field_table.' | ||
| write(*,*) ' Stopping execution.' | ||
| stop 999 |
There was a problem hiding this comment.
Stop statements may not abort a program correctly when using MPI. Should either import and use mpp_error or make a call to MPI_Finalize to properly abort execution.
There was a problem hiding this comment.
A few other places in this subroutine use the stop function to terminate the program. Should all of them be revised?
| @@ -2052,7 +2108,11 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, & | |||
| logical :: fixed_sollat = .false. !< flag to fix solar latitude | |||
| logical :: daily_mean = .false. !< flag to replace cosz with daily mean value | |||
|
|
|||
| !--- dynamical core parameters | |||
| logical :: dycore_hydrostatic = .true. !< whether the dynamical core is hydrostatic | |||
There was a problem hiding this comment.
The designed way to get this information to the physics from outside is to use the GFS_init_type. This type is populated with dycore and other external to the physics information within the atmos_model.F90::atmos_model_init function and it is passed to GFS_Initialize, where it is passed to the Model%init procedure.
There was a problem hiding this comment.
Hi Rusty, thanks for your guidance. I can move these variables to GFS_init_type. I will submit another merge request when it is done.
|
Since we no longer need compatibility with ufs as they've embraced CCPP, we
could start using FMS functions and change the write statements to
mpp_error statement. With the appropriate FATAL condition, mpi will be
properly terminated and any future coupled components running concurrently
will also get the termination signal.
…On Fri, Jun 2, 2023 at 4:01 PM linjiongzhou ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In GFS_layer/GFS_typedefs.F90
<#22 (comment)>
:
> + if (Model%ntke < 1 .or. Model%ntke > Model%ntrac) then
+ write(*,*) ' FATAL GFS_typedefs: TKE PBL scheme enabled (satmedmf) but TKE tracer not found in field_table.'
+ write(*,*) ' Stopping execution.'
+ stop 999
A few other places in this subroutine use the stop function to terminate
the program. Should all of them be revised?
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSKBVEULCRE6FE2LZ7LS6TXJJBBLANCNFSM6AAAAAAYW4AVZQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Hi, Rusty. Thank you for catching that, it is my mistake. However I had
thought that there is some technical limitation to including MPP routines
within the SHiELD physics. Is it just a matter of adding the correct 'use'
statement?
There are a lot of things in the SHiELD physics that can be replaced by
actively-developed GFDL functionality and hopefully as part of the coupled
SHiELD project we can work towards this.
[FYI don't feel you need to answer this during your vacation].
Lucas
On Fri, Jun 2, 2023 at 4:10 PM Rusty Benson ***@***.***>
wrote:
… Since we no longer need compatibility with ufs as they've embraced CCPP, we
could start using FMS functions and change the write statements to
mpp_error statement. With the appropriate FATAL condition, mpi will be
properly terminated and any future coupled components running concurrently
will also get the termination signal.
On Fri, Jun 2, 2023 at 4:01 PM linjiongzhou ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In GFS_layer/GFS_typedefs.F90
> <
#22 (comment)
>
> :
>
> > + if (Model%ntke < 1 .or. Model%ntke > Model%ntrac) then
> + write(*,*) ' FATAL GFS_typedefs: TKE PBL scheme enabled (satmedmf) but
TKE tracer not found in field_table.'
> + write(*,*) ' Stopping execution.'
> + stop 999
>
> A few other places in this subroutine use the stop function to terminate
> the program. Should all of them be revised?
>
> —
> Reply to this email directly, view it on GitHub
> <
#22 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABSKBVEULCRE6FE2LZ7LS6TXJJBBLANCNFSM6AAAAAAYW4AVZQ
>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVFGLNYKM6YI6HSODWLXJJCCRANCNFSM6AAAAAAYW4AVZQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
To ensure Rusty's comments are not forgotten as I have merged this PR, I created an issue: #23 |
|
Hi, Lauren. Thanks for setting this up.
Lucas
…On Tue, Jun 6, 2023 at 8:12 AM laurenchilutti ***@***.***> wrote:
To ensure Rusty's comments are not forgotten as I have merged this PR, I
created an issue: #23
<#23>
Please continue any discussion in the issue. Rusty will be unavailable for
the next few weeks.
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVGI3IYZAPKOSCZEO7LXJ4NBZANCNFSM6AAAAAAYW4AVZQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR publishes SHiELD_physics 202305 release. This release coincides with the release of GFDL_atmos_cubed_sphere 202305.
The changes included in this PR are from the GFDL FV3 Team. Full description of changes can be seen in the RELEASE.md
PRs that are all related and should be merged with this one:
NOAA-GFDL/GFDL_atmos_cubed_sphere#273
NOAA-GFDL/SHiELD_build#22
NOAA-GFDL/atmos_drivers#22
Fixes # (issue)
How Has This Been Tested?
Tested with the regression tests in SHiELD_build
Checklist:
Please check all whether they apply or not