Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename docker images #330

Open
esheehan-gsl opened this issue May 10, 2023 · 1 comment · May be fixed by #433
Open

Rename docker images #330

esheehan-gsl opened this issue May 10, 2023 · 1 comment · May be fixed by #433
Assignees

Comments

@esheehan-gsl
Copy link
Contributor

The names of our docker images no longer accurately reflect the current application architecture.

api
The Flask application that serves the entire application, not just the JSON data
ui
An nginx webserver that serves static assets and reverse proxies requests to the Flask app
data
The Lambda function for ETL of diagnostic data

We should probably rename api to app and ui to something like webserver or static.

@esheehan-gsl esheehan-gsl added this to the Cycle 2023.4 milestone Oct 3, 2023
@esheehan-gsl esheehan-gsl linked a pull request Nov 1, 2023 that will close this issue
@esheehan-gsl
Copy link
Contributor Author

@ian-noaa I was trying to get this one done myself (#433) but I’m having a devil of a time getting kubernetes to run locally so that I can test that my changes actually worked. So I think maybe I’d better hand this one over to you for whenever you have time to get to it.

It’s just some minor maintenance, so there’s no rush. And if you want to just delete the branch I created and start over you’re of course welcome to do so.

@esheehan-gsl esheehan-gsl removed this from the Cycle 2023.4 milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants