Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time series visualization #272

Merged
merged 20 commits into from
Apr 14, 2023
Merged

Conversation

esheehan-gsl
Copy link
Contributor

@esheehan-gsl esheehan-gsl commented Apr 5, 2023

Implement the API for retrieving historical summaries of model runs.

Stacked PRs

@esheehan-gsl esheehan-gsl linked an issue Apr 5, 2023 that may be closed by this pull request
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 5, 2023 16:13 — with GitHub Actions Inactive
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 5, 2023 16:13 — with GitHub Actions Inactive
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 6, 2023 15:23 — with GitHub Actions Inactive
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 6, 2023 15:24 — with GitHub Actions Inactive
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 7, 2023 15:04 — with GitHub Actions Inactive
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 7, 2023 15:05 — with GitHub Actions Inactive
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 7, 2023 15:57 — with GitHub Actions Inactive
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 7, 2023 15:59 — with GitHub Actions Inactive
I think I’ll want to replace some of the existing fixtures with a
combination of this one, and a reduced use for diag_zarr. This should
make it easier to generate arbitrary test data for any of our test cases
and might make it easier to write more comprehensive and comprehensible
tests.
This new fixture makes it easier for me to generate data for the tests
in a way that I can examine the responses for time series.
Added an endpoint that retrieves all of the historical data available
for a given model. We should be able to use this to display time series
data.
Apply filters to the historical data to exclude unused observations.
@esheehan-gsl esheehan-gsl force-pushed the 44-time-series-visualization-of-obs-guess branch from 35db51b to ebec078 Compare April 7, 2023 16:01
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 7, 2023 16:04 — with GitHub Actions Inactive
Make sure we catch empty datasets and return no values. Trying to call
.min() on an array with no values in it, throws an exception, so we need
to guard against that.
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 10, 2023 13:49 — with GitHub Actions Inactive
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 10, 2023 13:49 — with GitHub Actions Inactive
I don’t really know what these should look like or if they’re even
useful, so I’m going to kick this can down the road and just leave this
test here as a marker.
Register the web component for the time series chart
This way they’re easier to see because they’re not partially obscured by
the data (especially the y-axis).
@esheehan-gsl esheehan-gsl mentioned this pull request Apr 12, 2023
@esheehan-gsl esheehan-gsl added the stacked This PR is part of a series of PRs that represent changes of a single change broken up for review label Apr 12, 2023
@esheehan-gsl esheehan-gsl self-assigned this Apr 12, 2023
@esheehan-gsl esheehan-gsl marked this pull request as ready for review April 13, 2023 15:33
Create a web component for visualizing time series.

Stacked on #272
@github-actions
Copy link

Code Coverage

Package Line Rate Health
src.unified_graphics 91%
tests 88%
Summary 89% (594 / 665)

Minimum allowed line rate is 60%

@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 14, 2023 12:48 — with GitHub Actions Inactive
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 14, 2023 12:58 — with GitHub Actions Inactive
@esheehan-gsl esheehan-gsl merged commit 1e853f8 into main Apr 14, 2023
@esheehan-gsl esheehan-gsl deleted the 44-time-series-visualization-of-obs-guess branch April 14, 2023 13:12
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 14, 2023 13:12 — with GitHub Actions Inactive
@esheehan-gsl esheehan-gsl temporarily deployed to vlab April 14, 2023 13:12 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stacked This PR is part of a series of PRs that represent changes of a single change broken up for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time Series Visualization of Obs - Guess
1 participant