-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time series visualization #272
Merged
esheehan-gsl
merged 20 commits into
main
from
44-time-series-visualization-of-obs-guess
Apr 14, 2023
Merged
Time series visualization #272
esheehan-gsl
merged 20 commits into
main
from
44-time-series-visualization-of-obs-guess
Apr 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I’ll want to replace some of the existing fixtures with a combination of this one, and a reduced use for diag_zarr. This should make it easier to generate arbitrary test data for any of our test cases and might make it easier to write more comprehensive and comprehensible tests.
This new fixture makes it easier for me to generate data for the tests in a way that I can examine the responses for time series.
Added an endpoint that retrieves all of the historical data available for a given model. We should be able to use this to display time series data.
Apply filters to the historical data to exclude unused observations.
35db51b
to
ebec078
Compare
Make sure we catch empty datasets and return no values. Trying to call .min() on an array with no values in it, throws an exception, so we need to guard against that.
I don’t really know what these should look like or if they’re even useful, so I’m going to kick this can down the road and just leave this test here as a marker.
Register the web component for the time series chart
This way they’re easier to see because they’re not partially obscured by the data (especially the y-axis).
Merged
Create a web component for visualizing time series. Stacked on #272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
stacked
This PR is part of a series of PRs that represent changes of a single change broken up for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the API for retrieving historical summaries of model runs.
Stacked PRs