Increase the number of workers in the API service #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gunicorn recommends using 2-4*num_cores workers. Starting conservatively with 4 workers. Unfortunately Docker's `CMD` directive won't expand environment variables. We could use the `CMD` directive in shell mode in order to expand the env variable. However, that has its own issues with PID reaping which is something Gunicorn handles when it's PID 1.
Minimum allowed line rate is |
esheehan-gsl
approved these changes
Apr 24, 2023
ian-noaa
deleted the
304-increase-the-number-of-workers-in-the-api-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gunicorn recommends using 2-4*num_cores workers. Starting conservatively with 4 workers. Unfortunately Docker's
CMDdirective won't expand environment variables when used with JSON syntax. We could use theCMDdirective in shell mode in order to expand the env variable. However, that has its own issues with PID reaping which is something Gunicorn handles when it's called with JSON syntax and given PID 1.