-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the time series to the variable summaries #408
Restore the time series to the variable summaries #408
Commits on Jun 16, 2023
-
Update diag.history to read from parquet
Update the tests and the implementation for retrieving historical data. In the process, I simplified the response type. I think, in the future, if we want to select unadjusted O - F or just the historical observations, we should build that into the URL, rather than sending all of the data back to the client and letting the client pick what to view. This cuts down on data transfer and allows us to simplify our components when they read data, since they don't have to parse a nested JavaScript object.
Configuration menu - View commit details
-
Copy full SHA for 691c4cf - Browse repository at this point
Copy the full SHA 691c4cfView commit details -
Remove some unused code from the history implementation
Removed some of the dataclasses and functions that had been part of the history API which are no longer used, now that we have the Parquet implementation.
Configuration menu - View commit details
-
Copy full SHA for 4807605 - Browse repository at this point
Copy the full SHA 4807605View commit details
Commits on Jun 20, 2023
-
Test with a file:// prototocol
The diag.history function fails when there's a file:// prefix in the diag file path because apparently Pandas gets a little confused and tries to pass it to urllib instead of just opening the file.
Configuration menu - View commit details
-
Copy full SHA for 0b984f2 - Browse repository at this point
Copy the full SHA 0b984f2View commit details
Commits on Oct 4, 2023
-
Revert "Remove the time series for now"
This reverts commit 716a400.
Configuration menu - View commit details
-
Copy full SHA for 6e295ed - Browse repository at this point
Copy the full SHA 6e295edView commit details -
Use env variable to find Parquet files in routes
Instead of deriving the Parquet file path from the Zarr path, the route reads in the FLASK_DIAG_PARQUET variable from the environment and passes that explicitly to diag.history. diag.history uses that to find the Parquet file for this model, and strips out `file://` if it's present because Pandas is a bit silly about that.
Configuration menu - View commit details
-
Copy full SHA for b480a0d - Browse repository at this point
Copy the full SHA b480a0dView commit details -
Update property access for time series charts
The charts really need to be refactored (in part) to eliminate these hard-coded property accesses, but for now we can just update the properties that the time series component expects so that we can include test out the time series data.
Configuration menu - View commit details
-
Copy full SHA for 13bdd7f - Browse repository at this point
Copy the full SHA 13bdd7fView commit details
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 79aa304 - Browse repository at this point
Copy the full SHA 79aa304View commit details -
Use tmp_path to store parquet fixtures
Instead of deriving the path to save parquet fixtures for tests, we use tmp_path, basically the same way we would for production.
Configuration menu - View commit details
-
Copy full SHA for 9237851 - Browse repository at this point
Copy the full SHA 9237851View commit details -
Strip file protocol from diag zarr config
It seems like pathlib.Path is having an issue with the `file://` protocol on our environment variables, although I don't think it used to. It's easy enough to strip this, although this may require more robust path/uri handling in our tests.
Configuration menu - View commit details
-
Copy full SHA for 6cf5524 - Browse repository at this point
Copy the full SHA 6cf5524View commit details -
Fix data type for is_used in test fixtures
When we process diag files in our pipeline, we convert the integers in the diag files for is_used into booleans, so should treat them the same way in our test fixtures. I think this is a sign that our test fixtures are poorly set up, since they can get out of sync with reality. The result of this problem was that either the application worked, or our tests passed. Prior to this change, we needed to compare is_used to a boolean for Parquet files generated with our ETL code, but to an integer for test files generated with our fixtures.
Configuration menu - View commit details
-
Copy full SHA for 5d93be0 - Browse repository at this point
Copy the full SHA 5d93be0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbb6527 - Browse repository at this point
Copy the full SHA fbb6527View commit details