Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display historical counts of observations used #472

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

esheehan-gsl
Copy link
Contributor

Hacked in another line chart to display the count of used observations per run.

Copy-pasta the code for the ChartTimeseries web component to a new
component - ChartObsCount - that displays the number of used
observations over time. I'm struggling to come up with a set of
components that allows us to create more generalized charts without
hard-coding data access etc. This is an extremely stupid solution to
this problem, but it moves the project forward without over-engineering
the problem by inventing a whole charting primitives library from
scratch.
Since this chart is being treated as a representation of a specific set
of variables, it makes sense to give it a more specific name. It is not
a general-purpose time series.
@esheehan-gsl esheehan-gsl linked an issue Dec 15, 2023 that may be closed by this pull request
Copy link

Code Coverage

Package Line Rate Branch Rate Health
unified_graphics 80% 68%
unified_graphics.etl 97% 96%
utils.s3 68% 69%
Summary 84% (369 / 437) 81% (86 / 106)

Minimum allowed line rate is 60%

Copy link
Collaborator

@ian-noaa ian-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! We can always refactor the copy/pasted component later.

@esheehan-gsl esheehan-gsl merged commit 78eb565 into main Dec 18, 2023
13 checks passed
@esheehan-gsl esheehan-gsl deleted the 442-display-historical-counts-of-observations-used branch December 18, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display historical counts of observations used
2 participants