-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nwis client to canonical format #117
Comments
DeprecationWarning is suppresed by default. Changing to UserWarning. |
Update 1 implemented in #118 |
I think this might need to be reopened, @jarq6c. It appears that #185 did change the default value of |
Ah got me! I forgot about removing the warning! |
nwis_client
returns avalue_date
column. We will add avalue_time_label="value_date"
option to continue this behavior.Update 1: Add
value_time_label="value_date"
to__init__
that will raise a deprecation warning. Default behavior will returnvalue_date
.value_time_label="value_time"
will returnvalue_time
.Update 2: Default behavior is
value_time_label="value_time"
. Warn if this option is not explicitly set by user.Update 3: Default behavior is
value_time_label="value_time"
with no warning.The text was updated successfully, but these errors were encountered: