Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nwis client to canonical format #117

Closed
jarq6c opened this issue Jul 29, 2021 · 4 comments · Fixed by #185 or #187
Closed

Update nwis client to canonical format #117

jarq6c opened this issue Jul 29, 2021 · 4 comments · Fixed by #185 or #187
Assignees
Labels
enhancement New feature or request

Comments

@jarq6c
Copy link
Collaborator

jarq6c commented Jul 29, 2021

nwis_client returns a value_date column. We will add a value_time_label="value_date" option to continue this behavior.

Update 1: Add value_time_label="value_date" to __init__ that will raise a deprecation warning. Default behavior will return value_date. value_time_label="value_time" will return value_time.

Update 2: Default behavior is value_time_label="value_time". Warn if this option is not explicitly set by user.

Update 3: Default behavior is value_time_label="value_time" with no warning.

@jarq6c jarq6c added the enhancement New feature or request label Jul 29, 2021
@jarq6c jarq6c self-assigned this Jul 29, 2021
@jarq6c
Copy link
Collaborator Author

jarq6c commented Jul 29, 2021

DeprecationWarning is suppresed by default. Changing to UserWarning.

@jarq6c
Copy link
Collaborator Author

jarq6c commented Jul 29, 2021

Update 1 implemented in #118

@aaraney
Copy link
Member

aaraney commented Mar 20, 2022

I think this might need to be reopened, @jarq6c. It appears that #185 did change the default value of value_time_label to "value_time" (Update 3.). However, value_time_label still throws a UserWarning is a user passes None to value_time_label and then sets value_time_label to "value_date" not the, now canonical, "value_time".

@jarq6c
Copy link
Collaborator Author

jarq6c commented Mar 21, 2022

I think this might need to be reopened, @jarq6c. It appears that #185 did change the default value of value_time_label to "value_time" (Update 3.). However, value_time_label still throws a UserWarning is a user passes None to value_time_label and then sets value_time_label to "value_date" not the, now canonical, "value_time".

Ah got me! I forgot about removing the warning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants