Suppress NWIS Client value_time warning

[jarq6c]

Small PR to remove the check for value_time per #117 . Also, added a catch for an empty dataframe warning in one of the tests.

Additions

• None

Removals

• Check for value_time default.

Changes

• Empty dataframe warning in test is caught.

Testing

Notes

• Closes Update nwis client to canonical format #117

Todos

Checklist

• PR has an informative and human-readable title
• PR is well outlined and documented. See #12 for an example
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (see CONTRIBUTING.md)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
• Placeholder code is flagged / future todos are captured in comments
• Reviewers requested with the Reviewers tool ➡️

[jarq6c]

Passes all tests.

[aaraney]

Thanks for taking care of this, @jarq6c!

[aaraney]

Going ahead and deploying 3.2.1 of nwis_client. Ill post a comment with the deployment once it is live

[aaraney]

Up now

[aaraney]

I noticed a few warning when running the unit tests before uploading to pypi. namely:

===================================================================================================== warnings summary =====================================================================================================
venv/lib/python3.9/site-packages/pytest_aiohttp/plugin.py:28
  ~/github/hydrotools_fork/python/nwis_client/venv/lib/python3.9/site-packages/pytest_aiohttp/plugin.py:28: DeprecationWarning: The 'asyncio_mode' is 'legacy', switching to 'auto' for the sake of pytest-aiohttp backward compatibility. Please explicitly use 'asyncio_mode=strict' or 'asyncio_mode=auto' in pytest configuration file.
    config.issue_config_time_warning(LEGACY_MODE, stacklevel=2)

tests/test_nwis.py: 62 warnings
  ~/github/hydrotools_fork/python/nwis_client/venv/lib/python3.9/site-packages/pytest_aiohttp/plugin.py:33: DeprecationWarning: 'loop' fixture is deprecated and scheduled for removal, please use 'event_loop' instead
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

I can address these in a future PR when I fix the slow unit tests that are failing as well.

[jarq6c]

Thanks @aaraney !