Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup.py back to subpackages #129

Closed
wants to merge 1 commit into from
Closed

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Aug 24, 2021

setup.py with a void call to setuptools.setup() is required to install packages in editable mode.

Related to #128.

Additions

Removals

Changes

  • Add setup.py back to subpackages to enable installing in editable mode.

Testing

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

…y this is not required in the future and can be re-removed
@jarq6c
Copy link
Collaborator

jarq6c commented Aug 24, 2021

I have had no problems using pip to install these packages in edit mode with only a setup.cfg. I'll check back.

@aaraney aaraney mentioned this pull request Aug 24, 2021
10 tasks
@jarq6c
Copy link
Collaborator

jarq6c commented Aug 24, 2021

@aaraney What version of python3 and pip are you using? I tested this on Python 3.8.10 and pip 21.2.4 and I did not need a setup.py to install these packages in editable mode.

@aaraney
Copy link
Member Author

aaraney commented Aug 24, 2021

I have had no problems using pip to install these packages in edit mode with only a setup.cfg. I'll check back.

When I updated to pip 21.2.4 my issues went away and I was able to install in editable mode with --use-feature=in-tree-build. I checked the change log and downgraded versions programatically. This issue arrises pip <21.1.

@aaraney
Copy link
Member Author

aaraney commented Aug 24, 2021

It looks like 19.3.1 solved the issue of packages without setup.py. With this knowledge, I will go ahead and close this. I don't think it seems necessary to include this now that pip is two major versions ahead now.

@aaraney aaraney closed this Aug 24, 2021
@aaraney aaraney deleted the add-setuppy branch August 24, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants