Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nwis_client bug causing KeyError when station does not return data -- Updated #135

Merged
merged 9 commits into from
Sep 9, 2021
Merged

fix nwis_client bug causing KeyError when station does not return data -- Updated #135

merged 9 commits into from
Sep 9, 2021

Commits on Sep 3, 2021

  1. add helper method for creating empty canonical dataframe

    @aaraney
    aaraney committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    7985320 View commit details
    Browse the repository at this point in the history

  2. remove redundant code that returned an inproperly formatted dataframe

    @aaraney
    aaraney committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    de35100 View commit details
    Browse the repository at this point in the history

  3. return empty canonical dataframe if no data is retrieved from nwis. f… 

    …ixes NOAA-OWP#133
    @aaraney
    aaraney committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    58ee56a View commit details
    Browse the repository at this point in the history

  4. add empty dataframe test

    @aaraney
    aaraney committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    85d3e61 View commit details
    Browse the repository at this point in the history

  5. re-introduce code from de35100. this covers the case when (literally)… 

    … no data is returned from nwis. However, now returns a canonical df
    @aaraney
    aaraney committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    67d7687 View commit details
    Browse the repository at this point in the history

  6. add empty df warning message helper function. call it where empty dat… 

    …aframes can be returned by IVDataService.get
    @aaraney
    aaraney committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    cd559b3 View commit details
    Browse the repository at this point in the history

  7. bump patch version 3.0.4 -> 3.0.5

    @aaraney
    aaraney committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    b12a305 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Test against most recent canonical dataframe format

    @jarq6c
    jarq6c committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    6b4ec2a View commit details
    Browse the repository at this point in the history

  2. return empty dataframe compatible with specified value time label for… 

    … backwards compatibility
    @jarq6c
    jarq6c committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    d76d75c View commit details
    Browse the repository at this point in the history