Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nwis_client now requires _restclient >= 3.0.4 #140

Merged
merged 2 commits into from Oct 8, 2021
Merged

nwis_client now requires _restclient >= 3.0.4 #140

merged 2 commits into from Oct 8, 2021

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Oct 6, 2021 •
edited

nwis_client now requires _restclient >= 3.0.4.
bump nwis_client from 3.0.5 -> 3.0.6.
solves #100

Additions

Removals

Changes

  • nwis_client now requires _restclient >= 3.0.4.

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@aaraney
Copy link
Member Author

aaraney commented Oct 6, 2021

I missed typed e25d037's message.

bump nwis_client version 3.0.4 -> 3.0.5

it should be bump nwis_client version 3.0.5 -> 3.0.6

@jarq6c jarq6c merged commit b34d531 into NOAA-OWP:main Oct 8, 2021
@jarq6c jarq6c linked an issue Oct 8, 2021 that may be closed by this pull request
Jupyter Notebook RuntimeError: This event loop is already running #139
Closed
@aaraney aaraney deleted the pin_nwis_client_to_3_0_4_or_greater_of_restclient branch October 8, 2021 19:03
@aaraney
Copy link
Member Author

aaraney commented Oct 8, 2021 •
edited

nwis_client 3.0.6 is now live.

@aaraney
Copy link
Member Author

aaraney commented Oct 8, 2021

@jarq6c can you tag b34d531 with a release please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jupyter Notebook RuntimeError: This event loop is already running
2 participants
@aaraney @jarq6c