Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 153; _restclient pins aiohttp version to <=3.7.4.post0 #154

Merged
merged 2 commits into from Nov 3, 2021

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Nov 3, 2021

See #153. In short, aiohttp> 3.7.4.post0 causes aiohttp_client_cache to throw SyntaxError.

Changes

  • aiohttp pinned version to <=3.7.4.post0

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@aaraney
Copy link
Member Author

aaraney commented Nov 3, 2021

redeployed _restclient

@aaraney aaraney mentioned this pull request Nov 3, 2021
@jarq6c jarq6c merged commit 4dec547 into NOAA-OWP:main Nov 3, 2021
@aaraney aaraney deleted the fix_153 branch May 19, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants