Fix 160. **params arg in IVDataService.get now raises warning when case insensitively matches other parameters

[aaraney]

IVDataService.get's **params argument is susceptible to malformed case entries (i.e. service.get(startdt="2022-01-01", ...) should instead be service.get(startDT="2022-01-01", ...)). This PR resolves this issue. Now, the above case, or any case where a **params argument case insensitively matches a non-**params argument, throws a RuntimeWarning and notes the parameters that are likely malformed. This behavior should change to an exception once nwis_client > 3.0.X.

fixes #160.

Changes

• nwis_client.IVDataService.get throws RuntimeWarning when arguments in **params case insensitively match a non-**params argument. (i.e. service.get(startdt="2022-01-01", ...) the correct call is service.get(startDT="2022-01-01", ...))

Todos

• Throw RuntimeError once nwis_client > 3.0.X

Checklist

• PR has an informative and human-readable title
• PR is well outlined and documented. See #12 for an example
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (see CONTRIBUTING.md)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
• Placeholder code is flagged / future todos are captured in comments
• Reviewers requested with the Reviewers tool ➡️

[jarq6c]

I like the plan to transition from warnings to exceptions. I think using the decorator was a good idea to facilitate this.

Thanks for the contribution!

[aaraney]

I like the plan to transition from warnings to exceptions. I think using the decorator was a good idea to facilitate this.

Thanks for the contribution!

For sure! It was fun to become more familiar with python's inspect library.

If there are no open other comments, I think we can merge.

[aaraney]

See #176:

Changes

• alteration to goal set out in 174. Now, nwis_client > 3.1 will raise RuntimeError exception instead of RuntimeWarning when arguments in **params case insensitively match a non-**params argument. (i.e. service.get(startdt="2022-01-01", ...) the correct call is service.get(startDT="2022-01-01", ...)). Previously, the proposed warning to error timeline was nwis_client > 3.0.