Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.1.4 Fixes #1 #570

Merged
merged 4 commits into from
Oct 20, 2023
Merged

V2.1.4 Fixes #1 #570

merged 4 commits into from
Oct 20, 2023

Conversation

TylerSchrag-NOAA
Copy link
Contributor

Few more fixes for V2.1.4, notably:

  • HI NWM Ingest fix - Looks like we've been reading the forecast hour incorrectly on HI configuration NWM ingest for a while.
  • Couple more QA/QC fixes to your new timestamp columns and ROF configurations, @shawncrawley (as well as fixes to my previous fixes)

@TylerSchrag-NOAA TylerSchrag-NOAA added the bug Something isn't working label Oct 19, 2023
@TylerSchrag-NOAA TylerSchrag-NOAA added this to the V2.1.4 milestone Oct 19, 2023
shawncrawley
shawncrawley approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As always, thanks for doing cleanup crew on that.

@nickchadwick-noaa nickchadwick-noaa merged commit 3e0204c into ti Oct 20, 2023
@nickchadwick-noaa nickchadwick-noaa deleted the v2_1_4_fixes_1 branch October 20, 2023 16:44
@nickchadwick-noaa nickchadwick-noaa linked an issue Oct 27, 2023 that may be closed by this pull request
V 2.1.4 QA/QC and Fixes #572
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawncrawley shawncrawley shawncrawley approved these changes

Assignees

@TylerSchrag-NOAA TylerSchrag-NOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
V2.1.4
Development

Successfully merging this pull request may close these issues.

V 2.1.4 QA/QC and Fixes
3 participants
@TylerSchrag-NOAA @shawncrawley @nickchadwick-noaa