Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing stream features in NHDPlusHR Burnlines #13

Closed
fernando-aristizabal opened this issue Aug 28, 2020 · 5 comments
Closed

Missing stream features in NHDPlusHR Burnlines #13

fernando-aristizabal opened this issue Aug 28, 2020 · 5 comments
Assignees
@TrevorGrout-NOAA
Labels
bug Something isn't working
Milestone
FIM v3.0

Comments

@fernando-aristizabal
Copy link
Member

Missing features in NHDPlusHR burnline inputs possibly causing areas with no inundation (FNs). Investigate and resolve by possibly changing the input source. Correct for new input within preprocessing module.
@fernando-aristizabal fernando-aristizabal added the bug Something isn't working label Aug 28, 2020
@fernando-aristizabal fernando-aristizabal added this to the FIM 3.0.0 milestone Aug 28, 2020
Closed
@fernando-aristizabal
Copy link
Member Author

Related to #15 possibly

@TrevorGrout-NOAA
Copy link
Contributor

TrevorGrout-NOAA commented Sep 2, 2020 •
edited

I have noticed both the additional streams as well as the stream segments that are left out in HUC 111303 as well. Started a feature branch (full-stream-network) I have a couple ideas to test.

@TrevorGrout-NOAA
Copy link
Contributor

TrevorGrout-NOAA commented Sep 5, 2020 •
edited

Brief (incomplete) update: Both this issue ( #13) and #15 ultimately stem from the NHDPlusBurnLineEvent_subset.gpkg. However, this issue (#13) has a potential solution that is separate from #15. What appears to be causing the limited mapping is related to the run_by_unit.py step of defining how pixel catchments are delineated (flow_points_pixels.gpkg). Currently the flow_points_pixels.gpkg are created in the "Vectorize FEATURE ID Centroids" step and this is currently formed by using the flows_grid_boolean.tif layer (based on the NHDPlusBurnLineEvent_subset.gpkg). If the pixel catchment points are instead based on the dem derived streams, this improves the density of the pixel catchments and ultimately the HAND/REM grid. I will verify the mapping/statistics in next update.
Edit: The picture below is HUC 111303 (NHDPlusBurnLineEvent_subset: NHDPlusID=21000300138039 )
image

@fernando-aristizabal
Copy link
Member Author

What's the HUC and HydroID pictured above?

@TrevorGrout-NOAA
Copy link
Contributor

HUC 111303 (NHDPlusBurnLineEvent_subset: NHDPlusID=21000300138039)

Closed
This was referenced Sep 22, 2020
Closed
Closed
TrevorGrout-NOAA added a commit that referenced this issue Oct 1, 2020
@TrevorGrout-NOAA
Modified pixel catchment creation
c932b3d 
Pixel catchments were created using flows_grid_boolean
which contained gaps. Pixel catchments are now created
using the dem derived stream layer.

This addresses Github issue #13

Squashed commit of the following:

commit 42e7710
Merge: a374529 766ebc8
Author: Trevor Grout <trevor.grout@noaa.gov>
Date:   Mon Sep 28 22:35:01 2020 +0000

    merge with dev

commit a374529
Merge: f402cce cafb817
Author: Trevor Grout <trevor.grout@noaa.gov>
Date:   Mon Sep 28 15:59:15 2020 +0000

    Merge branch 'dev-levelpath-patch' into dev-pixel-catchments-using-dem-streams

commit cafb817
Author: BrianAvant-NOAA <brian.avant@noaa.gov>
Date:   Tue Sep 22 20:39:32 2020 +0000

    cleaned up

commit b9b3946
Author: BrianAvant-NOAA <brian.avant@noaa.gov>
Date:   Tue Sep 22 16:53:51 2020 +0000

    using levelpath nhdplus hr attribute to traverse network

commit f402cce
Author: TrevorGrout-NOAA <trevor.grout@noaa.gov>
Date:   Mon Sep 21 16:28:31 2020 -0500

    Modify stream layer for creation  of feature ID centroids to demDerived_streams layer
fernando-aristizabal added a commit that referenced this issue Oct 12, 2020
@fernando-aristizabal
Squashed commit of the following:
4c71267 
commit c932b3d
Author: Trevor Grout <trevor.grout@noaa.gov>
Date:   Thu Oct 1 14:40:53 2020 +0000

    Modified pixel catchment creation
    Pixel catchments were created using flows_grid_boolean
    which contained gaps. Pixel catchments are now created
    using the dem derived stream layer.

    This addresses Github issue #13
@TrevorGrout-NOAA TrevorGrout-NOAA mentioned this issue Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TrevorGrout-NOAA TrevorGrout-NOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
FIM v3.0
Development

No branches or pull requests
3 participants
@fernando-aristizabal @frsalas-noaa @TrevorGrout-NOAA