[1pt] Fix inundation nation pathing errors #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobHanna-NOAA
changed the title
|
@RyanSpies-NOAA : Hi Ryan. I took this one to the goal line. See testing notes embedded. If you are comfortable with it, can you approve it? Your call if you want to do more testing on it but it likely is ok. Note: I did not test or understand how to test the change the newer mannings file. |
config/params_template.env
Outdated
| @@ -47,7 +47,7 @@ export src_subdiv_toggle="True" | |||
| # text to append to output log and hydrotable file names (use for testing/debugging) | |||
| export vrough_suffix="" | |||
| # input file location with nwm feature_id and channel roughness and overbank roughness attributes | |||
| export vmann_input_file="$inputsDir/rating_curve/variable_roughness/mannings_global_06_12.csv" | |||
| export vmann_input_file="$inputsDir/rating_curve/variable_roughness/mannings_global_025_05.csv" | |||
There was a problem hiding this comment.
I don't think we want this changed?
There was a problem hiding this comment.
oh sorry. Not sure why that change was made. Anyways. I fixed it and put it back. :)
RyanSpies-NOAA
previously approved these changes
Dec 5, 2023
CarsonPruitt-NOAA
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of directly related issues were fixed in this PR.
The initial problem came from Issue #1025 which was about a pathing issue for the outputs directory. In testing that fix, it exposed a few other pathing and file cleanup issues which are now fixed. We also added more console output to help view variables and pathing.
Closes #1025
Changes
config/params_template.env: Updated for a newer mannings global file. Changed and tested by Ryan Spies.toolsinundate_mosiac_wrapper.py: Took out a misleading and non-required print statement.inundate_nation.py: As mentioned above.Testing
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>devbranch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>(e.g.dev-revise-levee-masking)devbranchpre-commithooks were run locally/foss_fim/, run:pytest unit_tests/)4.x.x.xMerge Checklist (For Technical Lead use only)