[1pt] PR: Upgrade base Docker image to GDAL v3.8.0 #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mluck
added
refactoring
mluck
changed the title
|
I did a bunch of testing on the code and it was fine. We won't official approve this until we can test it with Nikki next week to see if it passes the security tests. A huc was run against the old code base, then the new one and a fair bit of comparisons were done including looking carefully of key output geotiff files. Also ran the pre and post set through alpha testing and it was fine as well. So.. code is approved, just need the security test. |
Bumps [pycryptodomex](https://github.com/Legrandin/pycryptodome) from 3.19.0 to 3.19.1. - [Release notes](https://github.com/Legrandin/pycryptodome/releases) - [Changelog](https://github.com/Legrandin/pycryptodome/blob/master/Changelog.rst) - [Commits](Legrandin/pycryptodome@v3.19.0...v3.19.1) --- updated-dependencies: - dependency-name: pycryptodomex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…dal-3.8.0-pyflwdir
CarsonPruitt-NOAA
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades base Docker image to GDAL v3.8.0. In order to upgrade past GDAL v.3.4.3 (see #1029), TauDEM's
aread8was replaced with a module from thepyflwdirPython package. Supersedes #1038 and undoes #1047 in favor of upgrading the base Docker image that contains JDK 17 rather than installing it into a base container that uses JDK 11 in order to resolve #1029.Additions
src/accumulate_headwaters.py: Usespyflwdirto accumulate headwaters and threshold and create stream pixels.Changes
Dockerfile: Upgrade GDAL from v.3.4.3 to v.3.8.0; remove JDK 17 and TauDEMaread8andthreshold.PipfileandPipfile.lock: Addpyflwdirand upgrade Python version.src/delineate_hydros_and_produce_HAND.sh: Addsrc/accumulate_headwaters.pyand remove TauDEMaread8andthresholdTesting
Ran
fim_pipeline.shandsynthesize_test_cases.pyon HUCs 12040101.fim_pipeline.shcompleted without any error, and CSI and MCC for 100yr and 500yr BLE magnitudes remained identical to v.4.4.8.2.Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>devbranch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>(e.g.dev-revise-levee-masking)devbranchpre-commithooks were run locally/foss_fim/, run:pytest unit_tests/)4.x.x.xMerge Checklist (For Technical Lead use only)