-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ngen conf package #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this looks good.
I'm curious whether it would make sense to add a complementary ModuleConfig type instead of putting, e.g., CFE in the same hierarchy as BMIC, but that can be handled in the furture if deemed appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question will the fact that time from the NetCDF is returned in int64 (usually non seconds from Jan 1 1970 12:00, ,b/c of NumPy defaults) be problematic for this code?
"""Enumeration of the supported NGEN forcing provider strings | ||
""" | ||
CSV = "CsvPerFeature" | ||
NetCDF = "FIXME" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we have a working NetCDF provider this will, as already noted need to be updated but not necessarily in this pull request.
A python package for helping to programmatically build ngen realization files. It will be used alongside the ngen-cal package (and that package will likely get refactored into a similar namespace package
ngen.cal
???)Additions
ngen.config
packageTesting
Checklist
Target Environment support