Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ngen conf package #17

Merged
merged 20 commits into from
Jun 28, 2022
Merged

Conversation

hellkite500
Copy link
Member

A python package for helping to programmatically build ngen realization files. It will be used alongside the ngen-cal package (and that package will likely get refactored into a similar namespace package ngen.cal???)

Additions

  • ngen.config package

Testing

  1. The package contains it own set of unit tests, and a workflow was added to exercise them.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • MacOS

@hellkite500 hellkite500 requested a review from donaldwj May 27, 2022 14:14
@hellkite500 hellkite500 mentioned this pull request Jun 2, 2022
12 tasks
Copy link
Contributor

@robertbartel robertbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this looks good.

I'm curious whether it would make sense to add a complementary ModuleConfig type instead of putting, e.g., CFE in the same hierarchy as BMIC, but that can be handled in the furture if deemed appropriate.

Copy link
Contributor

@donaldwj donaldwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question will the fact that time from the NetCDF is returned in int64 (usually non seconds from Jan 1 1970 12:00, ,b/c of NumPy defaults) be problematic for this code?

"""Enumeration of the supported NGEN forcing provider strings
"""
CSV = "CsvPerFeature"
NetCDF = "FIXME"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have a working NetCDF provider this will, as already noted need to be updated but not necessarily in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants