Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMD has no rotation. #2

Open
iqxtreme opened this issue Jan 20, 2020 · 2 comments
Open

HMD has no rotation. #2

iqxtreme opened this issue Jan 20, 2020 · 2 comments

Comments

@iqxtreme
Copy link

iqxtreme commented Jan 20, 2020

In unitysdk_normal_2.0.18 , NoloVR_Controller.cs around line 137-142, shown below:

if (index == 0)
{
//pose.pos += pose.rot * new Vector3(0, 0.08f, 0.062f);
pose.rot = Quaternion.Euler(new Vector3(0, -yaw, 0));
//pose.pos -= pose.rot * new Vector3(0, 0.08f, 0.062f);
}

these codes freeze hmd rotation at purely zero, if they are removed, HMD can work well.
Why they exist here? for what?

@Hettylool
Copy link
Contributor

Most of the time, our SDK is used with the all-in-one machine or mobile phone. The HMD rotation uses the all-in-one machine or mobile phone instead of Nolo, so it's blocked here

@iqxtreme
Copy link
Author

Thank you.

Maybe it should be like this:

#if !UNITY_EDITOR && !UNITY_STANDALONE
if (index == 0)
{
//pose.pos += pose.rot * new Vector3(0, 0.08f, 0.062f);
pose.rot = Quaternion.Euler(new Vector3(0, -yaw, 0));
//pose.pos -= pose.rot * new Vector3(0, 0.08f, 0.062f);
}
#endif

Most of the time, our SDK is used with the all-in-one machine or mobile phone. The HMD rotation uses the all-in-one machine or mobile phone instead of Nolo, so it's blocked here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants