Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering fixes #303

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Rendering fixes #303

wants to merge 10 commits into from

Conversation

ExE-Boss
Copy link
Member

This PR implements a bunch of miscellaneous rendering fixes and improvements.

@ExE-Boss ExE-Boss added breaking change This is going to break stuff bug Confirmed bugs enhancement Nice to have features in progress Pull requests that are not yet ready to be merged and issues that are being worked on. minecraft 1.7 Affects Minecraft 1.7.x wrappers minecraft 1.8 Affects Minecraft 1.8.x wrappers labels Apr 23, 2017
@ExE-Boss ExE-Boss added this to the v0.1.0 milestone Apr 23, 2017
@ExE-Boss ExE-Boss self-assigned this Apr 23, 2017
@codecov-io
Copy link

codecov-io commented Apr 23, 2017

Codecov Report

Merging #303 into master will increase coverage by 0.25%.
The diff coverage is 4.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #303      +/-   ##
============================================
+ Coverage     16.99%   17.24%   +0.25%     
- Complexity      965      980      +15     
============================================
  Files           416      416              
  Lines         13165    13189      +24     
  Branches       1383     1391       +8     
============================================
+ Hits           2237     2275      +38     
+ Misses        10782    10768      -14     
  Partials        146      146
Impacted Files Coverage Δ Complexity Δ
...ore/wrapper/mc/forge/v18/launcher/ClientProxy.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../mc/forge/v18/wrapper/item/ItemWrapperMethods.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...c/forge/v17/wrapper/entity/forward/FWEntityFX.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...c/forge/v18/wrapper/entity/forward/FWEntityFX.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...orge/v18/wrapper/block/forward/FWTileRenderer.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...orge/v17/wrapper/block/forward/FWTileRenderer.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/main/java/nova/core/util/math/MatrixStack.java 100% <ø> (ø) 14 <0> (ø) ⬇️
...forge/v18/wrapper/render/forward/FWEmptyModel.java 0% <ø> (ø) 0 <0> (?)
...ore/wrapper/mc/forge/v17/launcher/ClientProxy.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/nova/core/render/texture/Texture.java 35.71% <0%> (+35.71%) 1 <0> (+1) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ee0f33...7426d8c. Read the comment docs.

@ExE-Boss ExE-Boss added this to In Progress in Minecraft Rendering Jun 20, 2017
@ExE-Boss ExE-Boss removed the enhancement Nice to have features label Oct 25, 2017
@ExE-Boss ExE-Boss added the rebase needed 🚧 This PR needs to resolve a merge conflict label Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This is going to break stuff bug Confirmed bugs in progress Pull requests that are not yet ready to be merged and issues that are being worked on. minecraft 1.7 Affects Minecraft 1.7.x wrappers minecraft 1.8 Affects Minecraft 1.8.x wrappers rebase needed 🚧 This PR needs to resolve a merge conflict
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants