Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When editing an scenario, its loaded twice #224

Closed
eorahil opened this issue Apr 9, 2017 · 1 comment
Closed

When editing an scenario, its loaded twice #224

eorahil opened this issue Apr 9, 2017 · 1 comment
Labels
bug
Milestone
2.1

Comments

@eorahil
Copy link
Contributor

eorahil commented Apr 9, 2017

Don't know if it's a need but it took my attention.
After donwloading the house lynch scenario, going to scenario edit and selecting it, The LOG shows
Loading quest from: "C:\Users\David\AppData\Roaming/Valkyrie\Download\TheFallofHouseLynch/quest.ini" twice.
Im working on loading at this poing the quest localization file and its called twice. is it correct or its a bug?
@eorahil eorahil changed the title When editing an scenario, it loaded twice When editing an scenario, its loaded twice Apr 9, 2017
@NPBruce NPBruce modified the milestones: 1.0.0, Post 1.0 Apr 9, 2017
@NPBruce NPBruce modified the milestones: 1.1.0, Post 1.1.0 Apr 21, 2017
@NPBruce NPBruce removed the question label May 2, 2017
@NPBruce NPBruce modified the milestones: Post 1.1.0, 1.1.0 May 9, 2017
@NPBruce NPBruce modified the milestones: Later, 2.1 Apr 23, 2018
BenRQ added a commit to BenRQ/valkyrie that referenced this issue Sep 29, 2018
@BenRQ
NPBruce#224 When editing an scenario, its loaded twice
82100c6 
Performance improvement: only one quest load for quest edition, and quest testing
@BenRQ
Copy link
Collaborator

BenRQ commented Sep 29, 2018

@redwolf2 should be fixed in next Brynhildr version

BenRQ added a commit that referenced this issue Oct 7, 2018
@BenRQ
#224 When editing an scenario, its loaded twice
8437b75 
Performance improvement: only one quest load for quest edition, and quest testing
@redwolf2 redwolf2 closed this as completed Oct 8, 2018
BenRQ added a commit that referenced this issue Oct 12, 2018
@BenRQ
#224 When editing an scenario, its loaded twice
149b3d4 
Performance improvement: only one quest load for quest edition, and quest testing
BenRQ added a commit that referenced this issue Oct 14, 2018
@BenRQ
#912 Editor - Save Function does not remove menu
2ef79a2 
Replace the old Reload() call with a simple remove dialog.
This was related to #224 optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
4 participants
@redwolf2 @eorahil @NPBruce @BenRQ