Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and Improve Valkyrie French translations #852

Closed
BenRQ opened this issue Jul 3, 2018 · 9 comments
Closed

Add and Improve Valkyrie French translations #852

BenRQ opened this issue Jul 3, 2018 · 9 comments
Milestone
2.1

Comments

@BenRQ
Copy link
Collaborator

BenRQ commented Jul 3, 2018

Hello,

I have spotted some missing French translations, mainly related to MoM Packs.

My commit is almost ready, but I can't find the location of the translations for the boxed expansions "streets of Arkham" and "sanctum of twilight".

I looked for text "twilight" in the whole repo, and for MAD26 which seems to be the tag for the Sanctum of Twilight expansion but without any success.

Some guidance on this would be welcome.

Valkyrie Version

I'm testing with Valkyrie 2.0.1

Fix will soon be available in my fork, I will do a pull request.
I'm new with Github though, but I should be able to do it right :)
@redwolf2
Copy link
Collaborator

redwolf2 commented Jul 4, 2018

I guess the text of "Sanctum of Twilight" and "Streets of Arkham" is taken from the texts, imported from the main app (PRODUCT_TITLE_MAD25 for example).

https://github.com/NPBruce/valkyrie/blob/master/unity/Assets/StreamingAssets/content/MoM/soa/content_pack.ini

So there should be no need to translate those.

@BenRQ
Copy link
Collaborator Author

BenRQ commented Jul 4, 2018

Thanks for the feedback !

Maybe the import is not taking into account the language selection then.
I have the MoM official app configured in French, and the title of the expansions are available in French too (at least one is : street of Arkham)
image

But I still have the text in English in Valkyrie, even after a new import.
image

It's not a big issue, but the titles of the expansions can be really different in French.

@BenRQ
Copy link
Collaborator Author

BenRQ commented Jul 4, 2018 •
edited

Maybe the issue is only for streets of Arkham.

The other one "Par-delà le seuil" (Beyond the threshold) is properly translated.

And Sanctum of twilight is not yet available in French :'(

I will commit my translations then.

BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 4, 2018
@BenRQ
NPBruce#852 Add and Improve Valkyrie French translations
562fee5
@BenRQ
Copy link
Collaborator Author

BenRQ commented Jul 4, 2018

Commit and pull request is done.

@redwolf2
Copy link
Collaborator

redwolf2 commented Jul 4, 2018 •
edited

Pull request is found here: #853

@redwolf2 redwolf2 mentioned this issue Jul 4, 2018
Closed
@redwolf2 redwolf2 mentioned this issue Jul 11, 2018
Closed
@redwolf2
Copy link
Collaborator

Pull request was replaced by this here: #856

BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 16, 2018
@BenRQ
NPBruce#852 [MoM] Additional improvement on French translations
27e8183 
- Add some é à, even on upper case words
- Make good use of the dynamic button size of NPBruce#859
- Reduce some texts to avoid overlap
BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 17, 2018
@BenRQ
Revert "NPBruce#852 [MoM] Additional improvement on French translations"
dc71419 
This reverts commit 27e8183.
BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 17, 2018
@BenRQ
Revert "NPBruce#852 [MoM] Additional improvement on French translations"
a6fdb52 
This reverts commit 27e8183.
BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 18, 2018
@BenRQ
NPBruce#852 [MoM] Additional improvement on French translations
8dd2048 
- Add some é à, even on upper case words
- Make good use of the dynamic button size of NPBruce#859
- Reduce some texts to avoid overlap
BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 18, 2018
@BenRQ
NPBruce#852 [MoM] Additional improvement on French translations
71ee477 
- Add some é à, even on upper case words
- Make good use of the dynamic button size of NPBruce#859
- Reduce some texts to avoid overlap
@BenRQ
Copy link
Collaborator Author

BenRQ commented Jul 18, 2018

Pull request #865

BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 25, 2018
@BenRQ
NPBruce#852 [MoM] Additional improvement on French translation
37cf548 
Small fix on mythos phase name
BenRQ added a commit to BenRQ/valkyrie that referenced this issue Jul 25, 2018
@BenRQ
NPBruce#852 [MoM] Additional improvement on French translation BenRQ …
3f28122 
…committed

- Improve french translation for puzzle actions
- Slightly rework image puzzle to avoid overlap (in all languages) and add a bit more room for 'skill'
BenRQ added a commit to BenRQ/valkyrie that referenced this issue Sep 3, 2018
@BenRQ
Merge fr translation clean (#11)
c1e1ea7 
* NPBruce#852 [MoM] Additional improvement on French translations

- Add some é à, even on upper case words
- Make good use of the dynamic button size of NPBruce#859
- Reduce some texts to avoid overlap
- Small fix on mythos phase name
- Improve French translation for puzzle actions
- Slightly rework image puzzle to avoid overlap (in all languages) and add a bit more room for 'skill'
@BenRQ
Copy link
Collaborator Author

BenRQ commented Sep 3, 2018

Beta test version is now available with implementation of this issue:
https://github.com/BenRQ/valkyrie/releases/tag/release%2F2.1%2FBrynhildr_2.1.0b

@BenRQ BenRQ closed this as completed Sep 3, 2018
@redwolf2
Copy link
Collaborator

redwolf2 commented Sep 5, 2018

Reopen, because it is fixed in Brynhildr, but not in Valkyrie. I created the label "Brynhildr" to track, what is covered by it.

@redwolf2 redwolf2 reopened this Sep 5, 2018
@redwolf2 redwolf2 added this to the 2.1 milestone Oct 5, 2018
BenRQ added a commit that referenced this issue Oct 7, 2018
@BenRQ
Merge fr translation clean (#11)
bc1fe68 
* #852 [MoM] Additional improvement on French translations

- Add some é à, even on upper case words
- Make good use of the dynamic button size of #859
- Reduce some texts to avoid overlap
- Small fix on mythos phase name
- Improve French translation for puzzle actions
- Slightly rework image puzzle to avoid overlap (in all languages) and add a bit more room for 'skill'
@redwolf2 redwolf2 closed this as completed Oct 8, 2018
BenRQ added a commit that referenced this issue Oct 12, 2018
@BenRQ
Merge fr translation clean (#11)
2975162 
* #852 [MoM] Additional improvement on French translations

- Add some é à, even on upper case words
- Make good use of the dynamic button size of #859
- Reduce some texts to avoid overlap
- Small fix on mythos phase name
- Improve French translation for puzzle actions
- Slightly rework image puzzle to avoid overlap (in all languages) and add a bit more room for 'skill'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@redwolf2 @BenRQ