Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Faucet Service + Valve Service #103

Merged
merged 14 commits into from
Feb 8, 2022
Merged

feat: Faucet Service + Valve Service #103

merged 14 commits into from
Feb 8, 2022

Conversation

Shaquu
Copy link
Member

@Shaquu Shaquu commented Oct 30, 2021

No description provided.

@Shaquu Shaquu marked this pull request as draft October 30, 2021 22:24
@Shaquu Shaquu marked this pull request as ready for review October 30, 2021 23:28
@Shaquu Shaquu requested a review from GogoVega October 30, 2021 23:35
@Shaquu
Copy link
Member Author

Shaquu commented Oct 30, 2021

Display preview:
https://617dd6c925c04b114eb6a1fb--naughty-raman-c58f41.netlify.app/wiki/service/faucet/

@Shaquu Shaquu mentioned this pull request Oct 30, 2021
Closed
@GogoVega
Copy link
Collaborator

GogoVega commented Nov 2, 2021 •
edited

So, since you want us to put our ideas here. I think it would take:

  • maybe change name of inject nodes by Close, Opening, Closing and Open
  • Add an example just open close (not InUse)

I forgot to add:

  • maybe interesting to add a link from ValveType table

Also a request to rearrange the nodes for more clarity

@Shaquu Shaquu marked this pull request as draft November 2, 2021 15:48
@GogoVega GogoVega added the documentation Improvements or additions to documentation label Feb 2, 2022
@GogoVega GogoVega changed the title feat: Faucet Service feat: Faucet Service + Valve Service Feb 2, 2022
@GogoVega GogoVega marked this pull request as ready for review February 2, 2022 11:35
crxporter
crxporter previously approved these changes Feb 3, 2022
View reviewed changes
@GogoVega GogoVega marked this pull request as draft February 4, 2022 20:04
@GogoVega
Copy link
Collaborator

GogoVega commented Feb 4, 2022

I forgot to upload the new images

@GogoVega GogoVega marked this pull request as ready for review February 4, 2022 20:20
crxporter
crxporter previously approved these changes Feb 8, 2022
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022 •
edited

🚀 Deployed on https://6202b2bb37f74d42b0b3911b--nrchkb.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 8, 2022 17:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 8, 2022 17:50 Inactive
@github-actions github-actions bot temporarily deployed to commit February 8, 2022 18:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 8, 2022 18:13 Inactive
@Shaquu Shaquu merged commit 2086fff into master Feb 8, 2022
@Shaquu Shaquu deleted the faucet branch February 8, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crxporter crxporter crxporter approved these changes

@caitken-com caitken-com Awaiting requested review from caitken-com caitken-com is a code owner

@TheNON75 TheNON75 Awaiting requested review from TheNON75 TheNON75 is a code owner

@GogoVega GogoVega Awaiting requested review from GogoVega

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shaquu @GogoVega @crxporter