Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Get HomeKit client IP/MAC #328

Closed
MattL0 opened this issue Oct 18, 2020 · 7 comments · Fixed by #333
Closed

[Feature Request]: Get HomeKit client IP/MAC #328

MattL0 opened this issue Oct 18, 2020 · 7 comments · Fixed by #333
Assignees
@crxporter
Labels
enhancement 👍 New feature or request
Projects
Release 1.3 NRCHKB 1.3.0

Comments

@MattL0
Copy link

MattL0 commented Oct 18, 2020

Is there a way to get the ip adress or mac adress or name of the homepod /iphone etc that is send a command?
@MattL0 MattL0 added the enhancement 👍 New feature or request label Oct 18, 2020
@Shaquu
Copy link
Member

Shaquu commented Oct 22, 2020

I believe it is possible but partially.

homebridge/HAP-NodeJS#559

But I guess only when you connect directly from iPhone and not through any HomeKit hub (Apple TV or iPad).

@Shaquu Shaquu changed the title [Feature Request]: [Feature Request]: Get HomeKit client IP/MAC Oct 22, 2020
@crxporter
Copy link
Member

Add me to the list of people who has thought this would be cool! I'd like to see where commands originated. Seems like I was thinking about this at one point...

We could check something in hap.context to see if it was an automation, siri command, button press in home app, etc. I'm not sure what's possible but anything available would be neat!

Shaquu added a commit that referenced this issue Jan 12, 2021
@Shaquu
Add client IP address to onSet message (msg.hap.session) #328
74c8d65
@Shaquu Shaquu linked a pull request Jan 12, 2021 that will close this issue
Release Candidate 1.3.0 #333
Merged
@Shaquu Shaquu added this to the Release 1.3 milestone Jan 12, 2021
@Shaquu
Copy link
Member

Shaquu commented Jan 12, 2021 •
edited

Please check on dev.
If you change value of a Service with Apple device it will report it's IP (onSet msg.hap.session)
If you do that via node-red then it will be empty

@crxporter
Copy link
Member

Implementation in dev branch (1.3 dev 34 and newer) is awesome.

Everyone please test if you'd like! It works great for me.

This issue will be closed once 1.3 is released.

@Shaquu
Copy link
Member

Shaquu commented Feb 21, 2021

Since 1.3.0-dev.36 it should be possible to obtain connection data on both onSet and onChange

@crxporter crxporter added this to To do in NRCHKB 1.3.0 via automation Mar 25, 2021
@crxporter crxporter moved this from To do to Testing in NRCHKB 1.3.0 Mar 25, 2021
@Shaquu Shaquu moved this from Testing to In progress in NRCHKB 1.3.0 Mar 25, 2021
@Shaquu Shaquu moved this from In progress to Testing in NRCHKB 1.3.0 Mar 25, 2021
@TheNON75 TheNON75 moved this from Testing to Done in NRCHKB 1.3.0 Mar 25, 2021
@TheNON75 TheNON75 moved this from Done to Testing in NRCHKB 1.3.0 Mar 25, 2021
@Shaquu Shaquu moved this from Testing to In progress in NRCHKB 1.3.0 Mar 25, 2021
@Shaquu Shaquu removed this from the Release 1.3 milestone Mar 25, 2021
@crxporter crxporter moved this from In progress to Done in NRCHKB 1.3.0 Mar 27, 2021
@crxporter
Copy link
Member

Done and functional in 1.3 dev 41. Watch for msg.hap.session to use this feature.

@crxporter
Copy link
Member

See this wiki page for an explanation of msg.hap.session:

https://github.com/NRCHKB/node-red-contrib-homekit-bridged/wiki/Output-Messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crxporter crxporter

Labels
enhancement 👍 New feature or request
Projects
No open projects
NRCHKB 1.3.0
  
Done
Release 1.3
Awaiting triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release Candidate 1.3.0 NRCHKB/node-red-contrib-homekit-bridged
3 participants
@Shaquu @MattL0 @crxporter