Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FFmpeg No such file or directory #495

Merged
merged 2 commits into from Aug 31, 2022
Merged

fix FFmpeg No such file or directory #495

merged 2 commits into from Aug 31, 2022

Conversation

twocolors
Copy link
Contributor

@twocolors twocolors requested a review from Shaquu as a code owner August 31, 2022 12:37
@Shaquu
Copy link
Member

Shaquu commented Aug 31, 2022

I guess it is related to the empty addiitonalCommand?

@twocolors
Copy link
Contributor Author

yes, this fixes the empty value of "addiitonalCommand"

If it is empty, then an error will be

node-red  | 2022-08-31T12:26:01.474Z CameraSource ffmpeg data:   Stream #0:0: Video: h264 (High), yuv420p(tv, progressive), 928x576, 20 fps, 20 tbr, 90k tbn
node-red  | 2022-08-31T12:26:01.476Z CameraSource ffmpeg data: : No such file or directory
node-red  | 2022-08-31T12:26:01.484Z CameraSource-Error ERROR: FFmpeg exited with code 1

because there are two spaces

-f rawvideo  -b:v 132k

@Shaquu Shaquu changed the base branch from master to dev August 31, 2022 16:05
Copy link
Member

@Shaquu Shaquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @twocolors

@Shaquu Shaquu merged commit 0a0b264 into NRCHKB:dev Aug 31, 2022
@Shaquu Shaquu added this to In progress in NRCHKB 1.5.0 via automation Aug 31, 2022
@Shaquu Shaquu mentioned this pull request Sep 2, 2022
@Shaquu Shaquu moved this from In progress to Review in progress in NRCHKB 1.5.0 Nov 20, 2022
Shaquu added a commit that referenced this pull request Nov 20, 2022
### Added

- Support for new advertiser [AVAHI](homebridge/HAP-NodeJS#918)
- Support for new advertiser [RESOLVED](homebridge/HAP-NodeJS#965)
- Added `msg.hap.reachable` parameter to get device reachable state (related to NO_RESPONSE)

### Fixed

- Accessory could not be recovered from NO_RESPONSE using single Characteristic
- Make unsupported Characteristic error more
  descriptive [#456](#456)
- FFmpeg No such file or directory [#495](#495)
- allChars: properties have spaces in names [#496](#496)
- Wait for host to return from unpublish/destroy before exiting, set published flag on destroy
- Security system with characteristics, bad behaviour [#388](#388)

### Changed

- Updated hap-nodejs to [0.9.7](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.9.7) (bug fixes)
- Updated hap-nodejs to [0.9.8](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.9.8) (bug fixes)
- Updated hap-nodejs to [0.10.0](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.10.0) (features)
- Updated hap-nodejs to [0.10.1](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.10.1) (changes)
- Updated hap-nodejs to [0.10.2](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.10.2) (bug fixes)
- Updated hap-nodejs to [0.10.3](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.10.3) (bug fixes)
- Updated hap-nodejs to [0.10.4](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.10.4) (bug fixes)
- Updated hap-nodejs to [0.11.0](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.11.0) (features and bug fixes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
NRCHKB 1.5.0
Review in progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants