Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allChars: properties have spaces in names #496

Closed
TheNON75 opened this issue Aug 31, 2022 · 3 comments
Closed

allChars: properties have spaces in names #496

TheNON75 opened this issue Aug 31, 2022 · 3 comments
Assignees
Labels
bug 🐛 There is at least high chance that it is a bug!

Comments

@TheNON75
Copy link
Collaborator

NRCHKB Plugin Version

1.4.3

Node JS Version

16

NPM Version

Official docker

Node-RED Version

2.x

Operating System

Official docker

What happened?

Periwrty names in allChars have spaces between the words unlike the properties used in the payload or accessory configuration.
Spaces should be removed to stay consistent

How to reproduce?

Check allChars in any msg

Expected behavior:

Spaces to be removed

Additional comments?

N/A

Relevant log output

No response

@Shaquu Shaquu self-assigned this Aug 31, 2022
@Shaquu Shaquu added the bug 🐛 There is at least high chance that it is a bug! label Aug 31, 2022
@Shaquu Shaquu added this to To do in NRCHKB 1.5.0 via automation Aug 31, 2022
@Shaquu
Copy link
Member

Shaquu commented Aug 31, 2022

Please test in 1.5.dev

Shaquu added a commit that referenced this issue Nov 20, 2022
### Added

- Support for new advertiser [AVAHI](homebridge/HAP-NodeJS#918)
- Support for new advertiser [RESOLVED](homebridge/HAP-NodeJS#965)
- Added `msg.hap.reachable` parameter to get device reachable state (related to NO_RESPONSE)

### Fixed

- Accessory could not be recovered from NO_RESPONSE using single Characteristic
- Make unsupported Characteristic error more
  descriptive [#456](#456)
- FFmpeg No such file or directory [#495](#495)
- allChars: properties have spaces in names [#496](#496)
- Wait for host to return from unpublish/destroy before exiting, set published flag on destroy
- Security system with characteristics, bad behaviour [#388](#388)

### Changed

- Updated hap-nodejs to [0.9.7](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.9.7) (bug fixes)
- Updated hap-nodejs to [0.9.8](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.9.8) (bug fixes)
- Updated hap-nodejs to [0.10.0](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.10.0) (features)
- Updated hap-nodejs to [0.10.1](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.10.1) (changes)
- Updated hap-nodejs to [0.10.2](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.10.2) (bug fixes)
- Updated hap-nodejs to [0.10.3](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.10.3) (bug fixes)
- Updated hap-nodejs to [0.10.4](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.10.4) (bug fixes)
- Updated hap-nodejs to [0.11.0](https://github.com/homebridge/HAP-NodeJS/releases/tag/v0.11.0) (features and bug fixes)
@Cyberbeni
Copy link

This was a breaking change btw.

@crxporter
Copy link
Member

Yes - kind of was breaking but ...

We decided it was a bugfix for the allChars property which was new in 1.4. The reasoning for this is everywhere else we use the property names, they have spaces removed. Spaces should have been removed in allChars the whole time but we didn't catch it before releasing the allChars feature.

In internal discussions (shaquu and I) decided this approach. Sorry for the breaking change, I had to change my flows in one spot also. Hope it didn't cause too much stress!!

Also closing since 1.5.0 is released.

NRCHKB 1.5.0 automation moved this from To do to Done Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 There is at least high chance that it is a bug!
Projects
Development

No branches or pull requests

4 participants