Persistent accessory identifier for subflows #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the use of nrchkb nodes in subflows with backwards compatibility.
This was
linked to
issues
Apr 26, 2021
Shaquu
requested changes
Apr 26, 2021
Shaquu
reviewed
Apr 26, 2021
Removing _flow and _alias from the HAP types and putting them into a generic node type, that just extends the node type of nodered. Changed a description that I did not adjust, when I changed the code. Made uniqueIdentifier a public property of HAPServiceNode.
Shaquu
approved these changes
Apr 27, 2021
|
Hey please flag me when it's ready to test so I remember. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #393, this pull request fixes the issue of changing identifiers in subflows. This is a non-breaking change, as identifiers for top level flows remain persistent. All existing nrchkb service nodes in subflows will create a new uuid for a last time and remain persistent afterwards.
It also resolves #298.
I also request to reject #236 as this pull request fixes the subflow issues without a breaking change and forcing users to use distinct serial numbers.