Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images_to_samples.py (hdf5s) --> data_to_tiles.py (tiles as tifs and geojsons) #215

Closed
remtav opened this issue Dec 7, 2021 · 3 comments · Fixed by #343
Closed

Images_to_samples.py (hdf5s) --> data_to_tiles.py (tiles as tifs and geojsons) #215

remtav opened this issue Dec 7, 2021 · 3 comments · Fixed by #343
Labels
enhancement New feature or request

Comments

@remtav
Copy link
Collaborator

remtav commented Dec 7, 2021

Features

  • CRS mismatch automatic handling
  • Resize image to new spatial resolution (ex.: 50cm to 25cm)
  • Don't rewrite tiles for an image that has all expected tiles
  • Crop geopackage to geojson (don't burn right away)
  • Input a csv directly (rush mode)
  • Input an image directly (for inference if pre-tiling is preferred?)
  • Parallelize tiling

Where to write tiles?

data_path / experiment_name / samples_folder_name ?
ex.:
geo_deep_learning/data/geobase_buildings/tiles_3bands_minannot1

How to deal with CRS mismatch?

  • to be discussed...

Onboarding solaris

  • How to integrate necessary solaris' utils?
  • 1st attempt
@remtav
Copy link
Collaborator Author

remtav commented Jan 20, 2022

Suggested logic for data_to_tiles.py

data_to_tiles_flow drawio

@remtav
Copy link
Collaborator Author

remtav commented Jan 20, 2022

Suggested class structure for use in data_to_tiles.py

classes_data_to_tile drawio

@remtav
Copy link
Collaborator Author

remtav commented Jan 24, 2022

Seeing comments from team members on Slack and Github, seems like this issue needs further discussion.
I suggest starting from a pros/cons table, then discussing it in a meeting based on this table.

Tiling approach Pros Cons
HDF5 *
Plain .geotiff/.geojson

*This type of table that expects a list of items is much easier done with Google Doc than Markdown

@victorlazio109 , @mpelchat04 , @ymoisan , @CharlesAuthier, please add/review the following Google Doc "Pros and Cons" table. This will serve as a basis for discussing the relevance of this PR and overall transition away from HDF5s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant